bgpd: fix to show exist/non-exist-map in 'show run' properly

[krishna-samy]

Currently, peergroup_filter_check() does not check whether exist-map or non-exist-map is configured along with advertise-map. This check is missing only when the peer is part of peergroup and having the exist/non-exist-map. So the 'show run' does not show the configured exist/non-exist-map as expected.

This new check is needed because, unlike other filter type the adv-map can have exist/non-exist-map additionally and we don't store this in the filter_override but store only the adv-map. So, a specific check is required to account the exist/non-exist-map while printing the adv-map config. Fixing the same by adding a check.

[ton31337]

Please create a topotest verifying this.

[ton31337]

Can you also show this how it looks in show running?

[krishna-samy]

Before fix:

r1(config-router-af)# neighbor 192.168.252.2 advertise-map v6_GLOBAL non-exist-map Temp
r1(config-router-af)# do sh run
Building configuration...
…

 neighbor 192.168.252.2 peer-group PG2
 !
 address-family ipv4 unicast
  neighbor 192.168.252.2 advertise-map v6_GLOBAL exist-map Temp
 exit-address-family
exit

UT after fix:

r1(config-router-af)# neighbor 192.168.252.2 advertise-map v6_GLOBAL non-exist-map Temp
r1(config-router-af)# do sh run
Building configuration...
…

 neighbor 192.168.252.2 peer-group PG2
 !
 address-family ipv4 unicast
  neighbor 192.168.252.2 advertise-map v6_GLOBAL non-exist-map Temp
 exit-address-family
exit


 
r1(config-router-af)# neighbor 192.168.252.2 advertise-map v6_GLOBAL exist-map Temp
r1(config-router-af)# do sh run
Building configuration...
…

 neighbor 192.168.252.2 peer-group PG2
 !
 address-family ipv4 unicast
  neighbor 192.168.252.2 advertise-map v6_GLOBAL exist-map Temp
 exit-address-family
exit
!
end

[ton31337]

@Mergifyio backport stable/10.3 stable/10.2 stable/10.1 stable/10.0

[mergify]

backport stable/10.3 stable/10.2 stable/10.1 stable/10.0

✅ Backports have been created

Details

• #18849 bgpd: fix to show exist/non-exist-map in 'show run' properly (backport #18828) has been created for branch stable/10.3 but encountered conflicts
• #18850 bgpd: fix to show exist/non-exist-map in 'show run' properly (backport #18828) has been created for branch stable/10.2 but encountered conflicts
• #18851 bgpd: fix to show exist/non-exist-map in 'show run' properly (backport #18828) has been created for branch stable/10.1
• #18852 bgpd: fix to show exist/non-exist-map in 'show run' properly (backport #18828) has been created for branch stable/10.0

[ton31337]

@Mergifyio rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[krishna-samy]

Please create a topotest verifying this.

done

[krishna-samy]

Can you also show this how it looks in show running?

done

[ton31337]

Please fix frrbot (python styling) and good to merge.

[krishna-samy]

Please fix frrbot (python styling) and good to merge.

done.

[riw777]

looks good