topotests: Add EVPN RT5 multipath flap test#18325
Merged
Jafaral merged 1 commit intoFRRouting:masterfrom Mar 20, 2025
Merged
Conversation
3a66d8a to
286abe4
Compare
Contributor
Author
|
fixed style |
09f9cf0 to
1be041c
Compare
Session flapping isn't tested which led to queuing / order issues in the past. This adds a second path between R1 and R2, after that both paths are flapped and the presence of the routerMac is checked Signed-off-by: Christopher Dziomba <[email protected]>
1be041c to
b6fc0a1
Compare
Contributor
Author
|
@riw777 I've slightly adjusted the RMAC test to use the same |
Jafaral
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a topotest for issues like #10298 and #12391, where L3-VNI RMACs were lost due to queueing issues.
After getting my way around topotests this is now the upstreamed version of a test we do internally for every FRR version before using it.
A second path is added between R1 and R2 in the
bgp_evpn_rt5topology, convergence is checked. Both paths are flapped alternately, checking for convergence and presence of the RMAC afterwards. Reverting #12524 (fix for #12391) breaks this test, as expected.