Skip to content

topotests: Add EVPN RT5 multipath flap test#18325

Merged
Jafaral merged 1 commit intoFRRouting:masterfrom
chdxD1:topotests/evpn-multipath-flap
Mar 20, 2025
Merged

topotests: Add EVPN RT5 multipath flap test#18325
Jafaral merged 1 commit intoFRRouting:masterfrom
chdxD1:topotests/evpn-multipath-flap

Conversation

@chdxD1
Copy link
Copy Markdown
Contributor

@chdxD1 chdxD1 commented Mar 6, 2025

This is a topotest for issues like #10298 and #12391, where L3-VNI RMACs were lost due to queueing issues.

After getting my way around topotests this is now the upstreamed version of a test we do internally for every FRR version before using it.

A second path is added between R1 and R2 in the bgp_evpn_rt5 topology, convergence is checked. Both paths are flapped alternately, checking for convergence and presence of the RMAC afterwards. Reverting #12524 (fix for #12391) breaks this test, as expected.

@chdxD1 chdxD1 force-pushed the topotests/evpn-multipath-flap branch from 3a66d8a to 286abe4 Compare March 6, 2025 13:19
@chdxD1
Copy link
Copy Markdown
Contributor Author

chdxD1 commented Mar 6, 2025

fixed style

Copy link
Copy Markdown
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@chdxD1 chdxD1 force-pushed the topotests/evpn-multipath-flap branch 3 times, most recently from 09f9cf0 to 1be041c Compare March 12, 2025 08:13
Session flapping isn't tested which led to queuing / order issues
in the past. This adds a second path between R1 and R2, after that
both paths are flapped and the presence of the routerMac is checked

Signed-off-by: Christopher Dziomba <[email protected]>
@chdxD1 chdxD1 force-pushed the topotests/evpn-multipath-flap branch from 1be041c to b6fc0a1 Compare March 12, 2025 08:14
@chdxD1
Copy link
Copy Markdown
Contributor Author

chdxD1 commented Mar 12, 2025

@riw777 I've slightly adjusted the RMAC test to use the same run_and_expect function. In the previous run there was a failure on that function for a single env, presumably because of timing issues.

@Jafaral Jafaral merged commit 361f80a into FRRouting:master Mar 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants