staticd: Fix SRv6 SID installation and deletion#18064
Merged
donaldsharp merged 3 commits intoFRRouting:masterfrom Feb 13, 2025
Merged
staticd: Fix SRv6 SID installation and deletion#18064donaldsharp merged 3 commits intoFRRouting:masterfrom
donaldsharp merged 3 commits intoFRRouting:masterfrom
Conversation
ahsalam
approved these changes
Feb 7, 2025
ahsalam
left a comment
ahsalam
left a comment
There was a problem hiding this comment.
The bug fix has been tested in SONiC and solves the problem. Thanks!
Contributor
|
So if I'm reading this correctly there is no topotest that actually validates this path? Could we please add a test, so we don't lose the correct functionality? |
Member
|
@Mergifyio backport dev/10.3 stable/10.2 |
✅ Backports have been createdDetails
|
The SRv6 support in staticd (PR FRRouting#16894) does not set the correct SID parameters (block length, node length, function length). This commit fixes the issue and computes the correct parameters. Signed-off-by: Carmine Scarpitta <[email protected]>
The `show ipv6 route json` command displays the IPv6 routing table in JSON format, including SRv6 SIDs. For each SRv6 SID, it provides behavior and SID attributes. However, it does not include the SID structure. This commit adds the SID structure to the SRv6 SID JSON output. Signed-off-by: Carmine Scarpitta <[email protected]>
The `static_srv6_sids` topotest verifies that staticd correctly programs the SIDs in the zebra RIB. Currently, the topotest only validates the programmed behavior and SID attributes. This commit extends the topotest to also validate the SID structure. Signed-off-by: Carmine Scarpitta <[email protected]>
cscarpitta
force-pushed
the
fix/fix_srv6_sid_parameters
branch
from
86e435b to
a6d02fe
Compare
Contributor
Author
@mjstapp Thanks for the suggestion. I extended the |
This was referenced Feb 13, 2025
Jafaral
added a commit
that referenced
this pull request
Feb 14, 2025
staticd: Fix SRv6 SID installation and deletion (backport #18064)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SRv6 support in staticd (PR #16894) does not set the correct SID parameters (block length, node length, function length).
This PR fixes the issue and computes the correct parameters.
The bug was reported by SONiC testing.