Skip to content

bgpd: Ensure that bgp open message stream has enough data to read#12247

Merged
ton31337 merged 1 commit intoFRRouting:masterfrom
donaldsharp:bgp_open_issues
Nov 2, 2022
Merged

bgpd: Ensure that bgp open message stream has enough data to read#12247
ton31337 merged 1 commit intoFRRouting:masterfrom
donaldsharp:bgp_open_issues

Conversation

@donaldsharp
Copy link
Member

If a operator receives an invalid packet that is of insufficient size then it is possible for BGP to assert during reading of the packet instead of gracefully resetting the connection with the peer.

Signed-off-by: Donald Sharp sharpd@nvidia.com

If a operator receives an invalid packet that is of insufficient size
then it is possible for BGP to assert during reading of the packet
instead of gracefully resetting the connection with the peer.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@frrbot frrbot bot added the bgp label Nov 2, 2022
@github-actions github-actions bot added the master label Nov 2, 2022
@ton31337
Copy link
Member

ton31337 commented Nov 2, 2022

@Mergifyio backport stable/8.4 stable/8.3

@mergify
Copy link

mergify bot commented Nov 2, 2022

backport stable/8.4 stable/8.3

✅ Backports have been created

Details

Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-8173/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@ton31337 ton31337 merged commit 4d9e033 into FRRouting:master Nov 2, 2022
Jafaral added a commit that referenced this pull request Nov 3, 2022
bgpd: Ensure that bgp open message stream has enough data to read (backport #12247)
Jafaral added a commit that referenced this pull request Nov 3, 2022
bgpd: Ensure that bgp open message stream has enough data to read (backport #12247)
DavidZagury added a commit to DavidZagury/sonic-buildimage that referenced this pull request May 17, 2023
DavidZagury added a commit to DavidZagury/sonic-buildimage that referenced this pull request May 17, 2023
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 5, 2023
…VE-2022-40302 (#15262)

Add patches from PRs
FRRouting/frr#12043
FRRouting/frr#12247

#### Why I did it
To fix CVEs found in FRR 8.2

#### How I did it
Take commit from  the FRR repo and created a patch from them
qiluo-msft pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 19, 2023
…22-40318… (#15263)

… CVE-2022-40302

Add patches from PRs
FRRouting/frr#12043
FRRouting/frr#12247

#### Why I did it
To fix CVEs GHSA-x7mf-v6gh-vm4g GHSA-9rqq-99cf-35g5 GHSA-j7hm-p94x-q9pw

##### Work item tracking
- Microsoft ADO **(number only)**: 23268946

#### How I did it
Added patches from the FRR fix PRs
yxieca pushed a commit to yxieca/sonic-buildimage that referenced this pull request Jun 19, 2023
…22-40318… (sonic-net#15263)

… CVE-2022-40302

Add patches from PRs
FRRouting/frr#12043
FRRouting/frr#12247

#### Why I did it
To fix CVEs GHSA-x7mf-v6gh-vm4g GHSA-9rqq-99cf-35g5 GHSA-j7hm-p94x-q9pw

##### Work item tracking
- Microsoft ADO **(number only)**: 23268946

#### How I did it
Added patches from the FRR fix PRs
yxieca added a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 20, 2023
…22-40318… (#15263) (#15537)

… CVE-2022-40302

Add patches from PRs
FRRouting/frr#12043
FRRouting/frr#12247

#### Why I did it
To fix CVEs GHSA-x7mf-v6gh-vm4g GHSA-9rqq-99cf-35g5 GHSA-j7hm-p94x-q9pw

##### Work item tracking
- Microsoft ADO **(number only)**: 23268946

#### How I did it
Added patches from the FRR fix PRs

Co-authored-by: DavidZagury <32644413+DavidZagury@users.noreply.github.com>
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
…VE-2022-40302 (sonic-net#15262)

Add patches from PRs
FRRouting/frr#12043
FRRouting/frr#12247

#### Why I did it
To fix CVEs found in FRR 8.2

#### How I did it
Take commit from  the FRR repo and created a patch from them
@donaldsharp donaldsharp deleted the bgp_open_issues branch July 30, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants