Skip to content

CMake 4 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 1, 2025
Merged

CMake 4 #144

merged 10 commits into from
Oct 1, 2025

Conversation

@ptheywood
Copy link
Member

@ptheywood ptheywood commented Sep 24, 2025 •
edited
Loading

Add Support for CMake 4.x

  • CI: On Windows install CUDA >= 12 from redist packages
  • CI: Add CMake CI includeing CMake 3.25.2, 3.31 and 4.x
    • Include Windows CMake builds - as linux is fine with CMake 4.x
  • Fix CMake warnings and errors with CMake 4.x
    • Bump dependencies
    • Address CMake 3.30+ deprecation of FetchContent_Populate(name)
    • Remove no longer required explicit policy setting due to increased minimum cmake
  • Update cmake_minimum_required upper bound to 4.1.1
  • Fixes Manylinux_2_28.yml filename

@ptheywood ptheywood mentioned this pull request Sep 24, 2025
Merged
6 tasks
@ptheywood ptheywood marked this pull request as ready for review September 30, 2025 12:12
@ptheywood ptheywood requested a review from mondus September 30, 2025 12:12
@ptheywood ptheywood force-pushed the cmake4 branch 4 times, most recently from f06e856 to 6b3348c Compare September 30, 2025 17:02
Base automatically changed from cuda-13 to master October 1, 2025 11:52
ptheywood added 10 commits October 1, 2025 13:41
@ptheywood
CI: On Windows install CUDA >= 12 from redist packages
c84a258
@ptheywood
CI: Add CMake workflow with 3.25.2, 3.31 and 4.x on linux and windows
018f81d
@ptheywood
CMake: Bump Freetype fetched on windows to 2.14.1 to for CMake 4 support
30497fe
@ptheywood
CMake: Fetch the latest CMakeRC rather than vendoring in a copy
a5c6897
@ptheywood
CMake: update cmake_minimum_required to 3.25.2...4.1.1
d8ae404
@ptheywood
CMake: Do not set CMP0135 to New
db5c92a 
This is no longer required as CMP0135 was introduced with CMake 3.24, which is now below our minimum of CMake 3.25.2
@ptheywood
Cmake: Do not set policy CMP0079 to New
c0ca628 
It was introduced in 3.13 which is below our minimum so not required
@ptheywood
CMake: Use FetchContent_MakeAvialable in place of Populate
19a7b2e 
FetchConent_Populate(name) was deprecated in CMake 3.30.

Using FetchContent_Declare(SOURCE_SUBDIR) with an invalid subdirectory allows for similar behaviour to before

Removes the workaround which set CMP0169 to OLD
@ptheywood
CI: Do not downgrade CMake to 3.x
8d184bb 
Use CMake 3.x to build Devil on Manylinux, as a CMake 4 compatible version is not availble
@ptheywood
CI: Fix Manylinux_2_28 workflow filename
090c46d
@ptheywood ptheywood merged commit 9282bf4 into master Oct 1, 2025
17 checks passed
@ptheywood ptheywood deleted the cmake4 branch October 1, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mondus mondus Awaiting requested review from mondus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ptheywood