feat: support multiple version solc and dev doc#846

Merged

kyonRay merged 1 commit intoFISCO-BCOS:devfrom

May 7, 2024

Contributor

HelloAldis commented Apr 28, 2024

support multiple version solc in console contract2java、deploy contract
support solidity devdoc for contract2java


          feat:

5d2ca74

1. support multiple version solc in console contract2java、deploy contract
2. support solidity devdoc for contract2java

sonarqubecloud bot commented Apr 28, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/console/common/ConsoleUtils.java

                       String smBinFilePath = smBinFile.getAbsolutePath();
-                      FileUtils.writeStringToFile(
-                              new File(abiDir + "/sm/" + contractName + ".abi"), abiAndBin.getAbi());
+                      FileUtils.writeStringToFile(smAbiFile, abiAndBin.getAbi());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [FileUtils.writeStringToFile](1) should be avoided because it has been deprecated.

src/main/java/console/common/ConsoleUtils.java

+                      File devdocFile = new File(docDir + contractName + ".devdoc");
+                      if (!StringUtils.isEmpty(abiAndBin.getDevdoc())) {
+                          FileUtils.writeStringToFile(devdocFile, abiAndBin.getDevdoc());

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [FileUtils.writeStringToFile](1) should be avoided because it has been deprecated.

src/main/java/console/contract/ConsoleContractImpl.java

-                                  logger.info(
-                                          "deploy contract {} with '--parallel-analysis' or '-p'", contractName);
+                                  inputParams.remove(lastIndexOf);
+                                  logger.info("deploy contract {} with '-p'", contractName);

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files

This [potentially sensitive information](1) is written to a log file.

src/main/java/console/contract/ConsoleContractImpl.java

+                              if (lastIndexOf != -1) {
+                                  isContractParallelAnalysis = true;
+                                  inputParams.remove(lastIndexOf);
+                                  logger.info("deploy contract {} with '--parallel-analysis'", contractName);

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files

This [potentially sensitive information](1) is written to a log file.

src/main/java/console/contract/ConsoleContractImpl.java

+                                  version = ConsoleUtils.convertStringToVersion(inputParams.get(lastIndexOf + 1));
+                                  inputParams.remove(lastIndexOf);
+                                  inputParams.remove(lastIndexOf);
+                                  logger.info("deploy contract {} with '-v'", contractName);

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files

This [potentially sensitive information](1) is written to a log file.

src/main/java/console/contract/ConsoleContractImpl.java

+                                  version = ConsoleUtils.convertStringToVersion(inputParams.get(lastIndexOf + 1));
+                                  inputParams.remove(lastIndexOf);
+                                  inputParams.remove(lastIndexOf);
+                                  logger.info("deploy contract {} with '--sol-version'", contractName);

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files

This [potentially sensitive information](1) is written to a log file.

src/main/java/console/contract/ConsoleContractImpl.java

+                      logger.debug(
+                              "compileSolToBinAndAbi, solc version:{} ,basePath: {}",
+                              Version.V0_8_11,
+                              solFile.getParentFile().getCanonicalPath());

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files

This [potentially sensitive information](1) is written to a log file.

kyonRay approved these changes

View reviewed changes

kyonRay merged commit d4ebca8 into FISCO-BCOS:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet