Skip to content

Conversation

@IgorBaratta
Copy link
Member

@IgorBaratta IgorBaratta commented Jan 21, 2021

Tests with classic Intel compilers are disabled due to an issue with pybind.
Once that is solved I can re-enable the tests.

Fix expected to pybind version 2.6.2:
pybind/pybind11#2771

Copy link
Member

@garth-wells garth-wells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we lost the C++ build test with the classic Intel compiler?

@jhale
Copy link
Member

jhale commented Jan 21, 2021 via email

@IgorBaratta
Copy link
Member Author

Have we lost the C++ build test with the classic Intel compiler?

Actually, the issue is building basix, it also uses pybind..
We can install it using gcc, to allow the C++ build test with the classic compiler.

@garth-wells
Copy link
Member

Actually, the issue is building basix, it also uses pybind..
We can install it using gcc, to allow the C++ build test with the classic compiler.

Ah, ok. Let's create an issue so we don't forget it.

@garth-wells
Copy link
Member

@jhale There's been quite a bit of work on pybind11 for the Intel classic compilers: pybind/pybind11#2573.

Also see pybind/pybind11#2769 and pybind/pybind11#2771.

@garth-wells garth-wells merged commit 673c52f into master Jan 21, 2021
@garth-wells garth-wells deleted the igor/test-intel-compiler branch January 21, 2021 18:33
@jhale
Copy link
Member

jhale commented Jan 22, 2021

Last time I checked there was an issue simply building C++ DOLFINX with Intel Classic, e.g. lines like this:

https://github.com/FEniCS/dolfinx/blob/master/cpp/dolfinx/fem/assemble_vector_impl.h#L542

Intel classic couldn't infer the template type of the function from the argument.

@garth-wells
Copy link
Member

Last time I checked there was an issue simply building C++ DOLFINX with Intel Classic, e.g. lines like this:

https://github.com/FEniCS/dolfinx/blob/master/cpp/dolfinx/fem/assemble_vector_impl.h#L542

Intel classic couldn't infer the template type of the function from the argument.

Intel class does work now for DOLFIN C++. Testing has been disabled because basix uses pybind11, which causes a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants