Skip to content

Conversation

@JanStreffing
Copy link
Collaborator

@JanStreffing JanStreffing commented Oct 16, 2025

Caution, AI at work, please check carefully ;-) @dsidoren

The recent bugfix in oce_mesh.F90 correctly reduced the elem2D_nodes allocation size from myDim_elem2D+eDim_elem2D+eXDim_elem2D to myDim_elem2D. However, the pointer association in associate_mesh_ass.h was not updated to match, causing 'Target of rank remapping is too small' errors. See:
/work/bb1469/a270092/runtime/awiesm3-v3.4/test_tco95_07/run_19900101-19900101/log/test_tco95_07_awiesm3_compute_20093047.log

This commit updates the pointer association to match the corrected array allocation size.

The error occurred only in Debug compile mode. Which is why it went undetected.

The recent bugfix in oce_mesh.F90 correctly reduced the elem2D_nodes
allocation size from myDim_elem2D+eDim_elem2D+eXDim_elem2D to myDim_elem2D.
However, the pointer association in associate_mesh_ass.h was not updated
to match, causing 'Target of rank remapping is too small' errors.

This commit updates the pointer association to match the corrected
array allocation size.

Fixes the regression introduced by the mesh reading bugfix.
@JanStreffing JanStreffing added this to the FESOM 2.7 milestone Oct 16, 2025
@JanStreffing JanStreffing self-assigned this Oct 16, 2025
@JanStreffing JanStreffing added the bug Something isn't working label Oct 16, 2025
@dsidoren
Copy link
Collaborator

Caution, AI at work, please check carefully ;-) @dsidoren

The recent bugfix in oce_mesh.F90 correctly reduced the elem2D_nodes allocation size from myDim_elem2D+eDim_elem2D+eXDim_elem2D to myDim_elem2D. However, the pointer association in associate_mesh_ass.h was not updated to match, causing 'Target of rank remapping is too small' errors. See: /work/bb1469/a270092/runtime/awiesm3-v3.4/test_tco95_07/run_19900101-19900101/log/test_tco95_07_awiesm3_compute_20093047.log

This commit updates the pointer association to match the corrected array allocation size.

The error occurred only in Debug compile mode. Which is why it went undetected.

AI, if it was seen in debugger mode we would have found it much earlier :)

@JanStreffing
Copy link
Collaborator Author

Problem is that we run of CI tests in release mode. This makes them a bit faster, but also less critical. Should we change that?

@JanStreffing JanStreffing merged commit 4c82029 into main Oct 16, 2025
14 checks passed
@JanStreffing JanStreffing deleted the fix_elem2d_nodes_allocation branch October 16, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants