Skip to content

Global tide module updated in 2.6.12, issue #404 fixed #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanStreffing merged 15 commits into from
Sep 8, 2025
Merged

Global tide module updated in 2.6.12, issue #404 fixed #764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
53c2ed3
Add Self-Attraction and Loading effect to surface pressure gradient (…
PengyangSong Aug 28, 2020
a2603f1
Add energy diagnosis for global tide work at each elem (in form of la…
PengyangSong Aug 28, 2020
c60b4c2
put a switch for opening/closing global tides in namelist.oce (defaul…
PengyangSong Sep 8, 2020
676bab4
small bugs fixed
PengyangSong Sep 28, 2020
29e1318
mesh focus bug
PengyangSong Nov 17, 2020
82d8f1e
need repmat here
PengyangSong Dec 1, 2020
6cc5fd7
fix conflict commit
PengyangSong Jan 25, 2021
c3440cb
prepare for pull
PengyangSong Jan 25, 2021
8e1fcad
delete the contribution of SAL
PengyangSong Mar 3, 2021
5d102e7
Merge pull request #115 from FESOM/master
koldunovn Apr 26, 2021
4979513
Merge pull request #118 from FESOM/master
koldunovn Apr 30, 2021
ffd920d
Merge pull request #134 from FESOM/master
koldunovn Jun 2, 2021
8d3850b
merge to 2.1
PengyangSong Jul 28, 2021
f34eff9
Merge latest changes from main into my branch global_tides.
PengyangSong Sep 7, 2025
36e5f03
Fixes #404: tide module fixed, move foreph_ini from fesom_runloop to …
PengyangSong Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/namelist.oce
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ visc_sh_limit=5.0e-3 ! for KPP, max visc due to shear instability
mix_scheme='KPP' ! vertical mixing scheme: KPP, PP
Ricr = 0.3 ! critical bulk Richardson Number
concv = 1.6 ! constant for pure convection (eqn. 23) (Large 1.5-1.6; MOM default 1.8)
use_global_tides=.false. ! add global tidal potential
/
9 changes: 5 additions & 4 deletions src/fesom_module.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,11 @@ subroutine fesom_init(fesom_total_nsteps)
call fesom_profiler_end("ocean_setup")
#endif

! global tides
if (use_global_tides) then
call foreph_ini(yearnew, month, f%partit)
end if

! recom setup
#if defined (__recom)
if (flag_debug .and. f%mype==0) print *, achar(27)//'[34m'//' --> call recom_init'//achar(27)//'[0m'
Expand Down Expand Up @@ -555,10 +560,6 @@ subroutine fesom_runloop(current_nsteps)
call fesom_profiler_start("fesom_runloop_total")
#endif
!___MODEL TIME STEPPING LOOP________________________________________________
if (use_global_tides) then
call foreph_ini(yearnew, month, f%partit)
end if

nstart=f%from_nstep
ntotal=f%from_nstep-1+current_nsteps

Expand Down
2 changes: 1 addition & 1 deletion src/oce_ale_vel_rhs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ subroutine compute_vel_rhs(ice, dynamics, partit, mesh)
! to velocity rhs
pre = -(p_eta+p_ice+p_air)
if (use_global_tides) then
pre=pre-ssh_gp(elnodes)
pre=pre-ssh_gp(elnodes)+0.1*p_eta
end if
Fx = sum(gradient_sca(1:3, elem)*pre)
Fy = sum(gradient_sca(4:6, elem)*pre)
Expand Down
2 changes: 1 addition & 1 deletion src/oce_modules.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ MODULE o_PARAM


NAMELIST /oce_dyn/ state_equation, C_d, A_ver, &
scale_area, SPP,&
scale_area, use_global_tides, SPP,&
Fer_GM, K_GM_max, K_GM_min, K_GM_bvref, K_GM_resscalorder, K_GM_rampmax, K_GM_rampmin, &
scaling_Ferreira, scaling_Rossby, scaling_resolution, scaling_FESOM14, &
Redi, visc_sh_limit, mix_scheme, Ricr, concv, which_pgf, alpha, theta, use_density_ref
Expand Down