Skip to content

Conversation

@mbutzin
Copy link
Collaborator

@mbutzin mbutzin commented Aug 8, 2025

Bugfix for missing CFC-11 tracer ID which affects all tagged versions >= 2.6

Bugfix for missing CFC-11 tracer ID which affects all tagged versions >= 2.6
@mbutzin mbutzin changed the title Update oce_setup_step.F90 Bugfix oce_setup_step.F90 Aug 8, 2025
@JanStreffing JanStreffing added this to the FESOM 2.7 milestone Aug 19, 2025
@JanStreffing JanStreffing self-requested a review September 8, 2025 10:05
@JanStreffing
Copy link
Collaborator

This seems to trip up the more strict GNU compiler during CI test:

[ 96%] Building Fortran object src/CMakeFiles/fesom.dir/oce_setup_step.F90.o
/__w/fesom2/fesom2/src/oce_setup_step.F90:1021:45:

 1021 |     use mod_transit, only: id_r14c, id_r39ar, id_if11, id_f12, id_sf6
      |                                             1
Error: Symbol 'id_if11' referenced at (1) not found in module 'mod_transit'
make[2]: *** [src/CMakeFiles/fesom.dir/build.make:1440: src/CMakeFiles/fesom.dir/oce_setup_step.F90.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:173: src/CMakeFiles/fesom.dir/all] Error 2

Could you have another look @mbutzin

@JanStreffing JanStreffing added the bug Something isn't working label Sep 8, 2025
Eliminate typo in line 1021
@mbutzin
Copy link
Collaborator Author

mbutzin commented Sep 8, 2025

This seems to trip up the more strict GNU compiler during CI test:

[ 96%] Building Fortran object src/CMakeFiles/fesom.dir/oce_setup_step.F90.o
/__w/fesom2/fesom2/src/oce_setup_step.F90:1021:45:

 1021 |     use mod_transit, only: id_r14c, id_r39ar, id_if11, id_f12, id_sf6
      |                                             1
Error: Symbol 'id_if11' referenced at (1) not found in module 'mod_transit'
make[2]: *** [src/CMakeFiles/fesom.dir/build.make:1440: src/CMakeFiles/fesom.dir/oce_setup_step.F90.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:173: src/CMakeFiles/fesom.dir/all] Error 2

Could you have another look @mbutzin

@mbutzin
Copy link
Collaborator Author

mbutzin commented Sep 8, 2025

"id_if11" is a typo which should read "id_f11" instead.

@JanStreffing JanStreffing merged commit 2d82154 into main Sep 8, 2025
9 checks passed
@JanStreffing JanStreffing deleted the mbutzin-patches-CFC11-1 branch September 8, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants