-
Notifications
You must be signed in to change notification settings - Fork 67
Fix meshpart build #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix meshpart build #722
Conversation
|
tested on levante with nv compilers and locally, PR is ready. |
|
Adding @sebastianbeyer as reviewer, as he last worked on this part of the code. Furthermore: Version 3.25 released in November 2022. This seems quite strict. I think there might be some HPC systems out there that have older versions of cmake. What part(s) are missing in 3.16? |
|
totally agree, thats what i meant above (and others like it blocks compilation for other compilers). Line 454 in ab846d0
we can also use block if we wrap in a function and specify we can only use it in cmake version above etc, I will address this later when we have more build targets (planned). |
|
Pardon, I did not read what you wrote. Just looked at the diff. My bad. |
|
Quick scan of supported HPC systems showed none of them use cmake older than 3.26. Chances of newer systems having older cmake version is slim. |
|
and even so cmake gives binaries that work out of the box for most machines, https://github.com/Kitware/CMake/releases |
|
So we found the first maschine that has only make 3.20.2 and not module. It's albedo. |
currently meshpart build has by default meshpartitioner is on always and cant be disabled because of its use in fesom export, which is fine but mesh partitioner is only build for gnu and intel so it creates issue when used with other compilers as @basava70 was using nvhpc on levante, this PR addresses minor fix to it.
cmake minimum version change: use of block in new cmake is supported only from cmake 3.25, can be problematic in some machines, (for instance recent ubuntu LTS has cmake 3.23) we can address this later when issue arises, but it is better to delegate error message to cmake minimum version required is 3.25 then block statement not found. As we increase cmake versions older versions will be depricated so metis cmake minimum version was bumped up without issues.
not addressed: Partitioner fortran interfaces are not installed because of fesom_export. I plan to have more install targets in the future, it is better to address this later.