Cavity bugfix: from linfs to rigid lid #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 14, 2025 12:09
…lowup. Therefore the best way to treat cavity is still rigid lid. This commit is to chnage back from my previous commit 0f64ece.
…tter if you use linfs/zstar in the open ocean.
…you really want to take this pressure effect into account, it is already coded with use_cavity_fw2press in subroutine compute_ssh_rhs_ale (with an explicit method, alpha=1)
JanStreffing
approved these changes
Apr 15, 2025
Collaborator
Author
|
@patrickscholz Could you have a look on my commits here? |
Contributor
|
@PengyangSong: Can you provide a bit more information, whats happening with the blowup? Are we speaking about standalone or coupled, which setup, linfs or zstar, where exactly does it blowup and under which conditions. Usually a model doesnt blowup after +100 years where it already run stable ? Is the ssh drifting ? ... |
| if (.not. trim(which_ALE)=='linfs') then | ||
| !$OMP PARALLEL DO | ||
| do n=1,myDim_nod2D | ||
| if (ulevels_nod2D(n)>1) cycle |
Contributor
There was a problem hiding this comment.
this change here affects the zstar case the upper change in line 1931 will affect the linfs case ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With linfs in cavity, the model cannot run for >100 years due to
sshblowup. Therefore we need to change it back to rigid lid.In
oce_ale.F90, it works like:compute_ssh_rhs_alecomputessh_rhs, cavity values are not zero.solve_ssh_alesolvesd_eta, cavity values are not zero.update_velincludes barotropic pressure gradient ofd_eta.compute_hbar_alemakes no change in cavity layer thicknesshbar.eta_n, so it is always zero.