Small fixes for iceberg module, that allow compiling with intel debug flags #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suvarchal
approved these changes
Jan 12, 2025
| if(dz < 1) then | ||
| !write(*,*) 'z coord of up node', n_up, ':', coord_nod3D(3, n_up), 'z coord of low node', n_low, ':', coord_nod3D(3, n_low) | ||
| call par_ex | ||
| call par_ex (partit%MPI_COMM_FESOM, partit%mype) |
Collaborator
There was a problem hiding this comment.
yes this is what it should be.
Collaborator
There was a problem hiding this comment.
not sure about this, shouldn't the subroutine be inside the module, and use this module when we use alllocate_icb. anyways module it is not being used anywhere in this PR. so is redundant.
Collaborator
There was a problem hiding this comment.
but lets fix it another day and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ackerlar can you, please have a look if this makes sense and if I did not break anything? :)