feat: Migrate database to v2 #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandryllo
changed the title
MiroDojkic
reviewed
Oct 31, 2025
| opts: pulumi.ComponentResourceOptions = {}, | ||
| ) { | ||
| super('studion:Database', name, {}, opts); | ||
| super('studion:LegacyDatabase', name, {}, opts); |
MiroDojkic
reviewed
Oct 31, 2025
| */ | ||
| skipFinalSnapshot?: pulumi.Input<boolean>; | ||
| /** | ||
| * The allocated storage in gibibytes. Defaults to 20GB. |
Member
There was a problem hiding this comment.
gibibyte, I like it. 👌 😂
On a serious note, we can drop comments where the name of the parameter is self-explanatory.
Collaborator
There was a problem hiding this comment.
Correct abbreviation for gibibyte is GiB so the typo should be fixed.
Sorry for barging in, I get notified for all activity and couldn't resist on this one 😄
MiroDojkic
reviewed
Oct 31, 2025
| return encryptedSnapshotCopy; | ||
| } | ||
|
|
||
| private createDatabaseInstance(args: Database.Args) { |
Member
There was a problem hiding this comment.
Let's avoid passing the whole argument bag, and instead make the parameters of each method explicit.
# Conflicts: # src/v2/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70
Tasks: