-
Notifications
You must be signed in to change notification settings - Fork 1
Feature: Enable multiple EFS volumes and mount points #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Enable multiple EFS volumes and mount points #24
Conversation
|
@droguljic I've yet to add examples and some default options, but I wanted to first verify with you if this approach makes sense. I can see us using multiple volumes and mount points. I assume we'd usually use the same EFS instance in most use cases. |
Makes sense, looks good to me. |
711294d to
e82f3fc
Compare
e82f3fc to
b2702bc
Compare
I would add that owner is first created non-root user, and this was included to support best practice to not run containers as root. |
src/components/ecs-service.ts
Outdated
| { | ||
| fileSystemId, | ||
| posixUser: { | ||
| uid: 1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we name these magic numbers? For example const ROOT_USER_ID = 1000;.
src/components/ecs-service.ts
Outdated
| creationInfo: { | ||
| ownerUid: 1000, | ||
| ownerGid: 1000, | ||
| permissions: '0755', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put this in a variable so it has a name? For example READ_PERMISSIONS.
| mountPoint => ({ | ||
| containerPath: mountPoint.containerPath, | ||
| sourceVolume: mountPoint.sourceVolume, | ||
| readOnly: mountPoint.readOnly ?? false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about ?? operator 😄
Multiple EFS Volumes and Mount Points Support
This PR adds support for configuring multiple EFS volumes and mount points in the MongoDB and ECS services, along with improved documentation.
Changes
Features
/dataDocumentation
persistentStorageConfigparameter documentationAPI Changes
Mongo Service
The Mongo service now comes with a default persistent storage configuration. Alternatively, user can provide volumes and mount points with the same config data structure: