Skip to content

AngleToVector2Direction the conversion is not conventional #539

@fight4dream

Description

@fight4dream

my intuition of it is given an angle, say DoTransform(30degs), it will output Transformed(Vector2( cos(30degToRad), sin(30degToRad) ))
after wired things up, i discover it isn't. so the code says:

  1. there is an internal 'currentAngle', we'll increment it by the input angle every time we call transform,
  2. the direction is normalized by 1f / Mathf.Max(Mathf.Abs(Direction.x), Mathf.Abs(Direction.y));

so i guess it is made this way because of input axis prefab needed this kind of manipulation,
but comparing this component among others, it shouldn't have incremented a hidden angle,
some components that provides increment feature would have both Set() and Increment()

also the special normalization would better be another component's duty

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions