-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: Refreshing Stay organized with workspace page user lands to what's your name page #76935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…'s your name page
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-08.at.00.14.45.android.movAndroid: mWeb ChromeScreen.Recording.2025-12-08.at.00.12.29.android.chrome.moviOS: HybridAppScreen.Recording.2025-12-08.at.00.25.39.moviOS: mWeb SafariScreen.Recording.2025-12-08.at.00.16.12.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2025-12-08.at.00.09.44.web.mov |
hoangzinh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.2.74-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
Explanation of Change
fix: Refreshing Stay organized with workspace page user lands to what's your name page
Fixed Issues
$ #75605
PROPOSAL: #75605 (comment)
Tests
Offline tests
None
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-07.at.21.30.23.mov
Android: mWeb Chrome
Screen.Recording.2025-12-07.at.21.31.03.mov
iOS: Native
Screen.Recording.2025-12-07.at.21.28.50.mov
iOS: mWeb Safari
Screen.Recording.2025-12-07.at.21.27.59.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-07.at.21.26.58.mov