fix: missing animations in #76890

kirillzyusko · 2025-12-06T15:56:29Z

Explanation of Change

Updated keyboard controller to the latest version that contains a fix for #75139 bug

Fixed Issues

$ #75139
PROPOSAL:

Tests

Open hybrid app
Switch to OldDot if you are not there
Switch to New Dot
Open any chat
Make sure content gets animated along with keyboard movement

Offline tests

N/A

QA Steps

Open hybrid app
Switch to OldDot if you are not there
Switch to New Dot
Open any chat
Make sure content gets animated along with keyboard movement

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-01-06.at.13.31.44.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2025-12-06T15:56:38Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2025-12-06T16:05:46Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...dingView/BaseKeyboardAvoidingView/index.native.tsx	`100.00% <ø> (ø)`
... and 6 files with indirect coverage changes

github-actions · 2025-12-06T16:52:43Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-10T18:23:40Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-10T18:48:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #76890.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/76890/index.html
The QR code can't be generated, because the Android build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/76890/NewExpensify.dmg	https://76890.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2025-12-17T11:41:31Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-17T11:48:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #76890.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

github-actions · 2025-12-19T13:18:42Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-19T13:41:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #76890.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/76890/index.html
The QR code can't be generated, because the Android build failed

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

github-actions · 2025-12-29T13:15:28Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-29T13:50:02Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-29T14:01:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #76890.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/76890/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/76890/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

github-actions · 2025-12-29T14:08:56Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-29T14:28:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #76890.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/76890/NewExpensify.dmg	https://76890.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2025-12-29T14:34:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #76890.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

github-actions · 2026-01-06T13:13:07Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-06T13:51:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #76890.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

github-actions · 2026-01-07T13:07:53Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-07T13:51:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #76890.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1684b73b6cce4c9848cc5e69fd34da0d693455b0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fc60a419a3b0764c231bd22aa94bfa6e23abd2b5/index.html

Desktop 💻	Web 🕸️
N/A	⏩ SKIPPED ⏩
N/A	The build for Web was skipped

👀 View the workflow run that generated this build 👀

mountiny · 2026-01-07T14:14:54Z

Noted here that his works https://expensify.slack.com/archives/C05LX9D6E07/p1767795263450079?thread_ts=1767052635.740169&cid=C05LX9D6E07

situchan · 2026-01-08T14:58:45Z

I know But it's a bit confusing Because I also checked on standalone And I had the same pods as in your zip file

ok then what's the issue? Seems all good.

ZhenjaHorbach · 2026-01-08T15:01:13Z

I know But it's a bit confusing Because I also checked on standalone And I had the same pods as in your zip file

ok then what's the issue? Seems all good.

I'm pretty sure that @kirillzyusko installed hybrid pods
And I wouldn't be surprised if we have the wrong pods because of this
But Kirill has the right ones

situchan · 2026-01-08T15:03:54Z

Here's hybrid pod: (to be added in Mobile-Expensify/iOS)

Podfile.lock.zip

…e window

OSBotify · 2026-01-08T18:19:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

rohit9625 · 2026-01-09T14:29:54Z

I'm having this issue when running Expensify New Dot in iOS Emulator. I suspect probably because of this version upgrade. I even tried re-clonning and every possible clean that I could do but no luck. Related slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1767943960054069

This is the issue:

ZhenjaHorbach · 2026-01-09T16:14:32Z

I'm having this issue when running Expensify New Dot in iOS Emulator. I suspect probably because of this version upgrade. I even tried re-clonning and every possible clean that I could do but no luck. Related slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1767943960054069

This is the issue:

Looks like it's just dev issue
But even on dev build I don't have this issue
But we will fix it!

And sorry
But did you try to click dismiss?

rohit9625 · 2026-01-09T18:23:47Z

And sorry But did you try to click dismiss?

Yes, I tried dismiss, and it appeared again.

OSBotify · 2026-01-09T20:00:55Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.97-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-10T02:20:01Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…r-missing-animations" This reverts commit 6620f4c, reversing changes made to 6eb4a7e.

francoisl · 2026-01-13T01:21:39Z

Heads up this ended up causing a crash in #79313, I'm reverting the PR.

[CP Staging] Revert #76890 – "fix: missing animations in"

[CP Staging] Revert #76890 – "fix: missing animations in" (cherry picked from commit 7cae749) (cherry-picked to staging by francoisl)

OSBotify · 2026-01-13T03:11:31Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.2.99-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-13T03:38:32Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-14T02:54:52Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.3.0-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned kirillzyusko Dec 6, 2025

kirillzyusko force-pushed the fix/keyboard-controller-missing-animations branch from f9e9351 to 31e1be4 Compare December 6, 2025 16:46

This comment has been minimized.

Sign in to view

kirillzyusko force-pushed the fix/keyboard-controller-missing-animations branch from 31e1be4 to 094e3e5 Compare December 29, 2025 12:20

mountiny self-assigned this Jan 6, 2026

kirillzyusko force-pushed the fix/keyboard-controller-missing-animations branch from 677cb7d to 074051f Compare January 6, 2026 15:02

kirillzyusko marked this pull request as ready for review January 7, 2026 15:41

kirillzyusko requested review from a team as code owners January 7, 2026 15:41

melvin-bot bot requested a review from ZhenjaHorbach January 7, 2026 15:41

kirillzyusko added 6 commits January 8, 2026 20:50

fix: missing animations in

2fd1523

fix: apply patch to RNKC that doesn't attach tracking view to inactiv…

4d1a5bc

…e window

fix: revert unnecessary changes

5a7699d

fix: revert reanimated flag

3385ef9

fix: update reanimated checksum

7404137

fix: revert unnecessary changes in Podfile.lock

e1495a0

kirillzyusko force-pushed the fix/keyboard-controller-missing-animations branch from f6add51 to e1495a0 Compare January 8, 2026 17:51

mountiny approved these changes Jan 8, 2026

View reviewed changes

mountiny merged commit 6620f4c into Expensify:main Jan 8, 2026
39 checks passed

OSBotify mentioned this pull request Jan 9, 2026

Deploy Checklist: New Expensify 2026-01-09 #79227

Closed

77 tasks

jponikarchuk mentioned this pull request Jan 10, 2026

[Due for payment 2026-01-21] App crashes when transitioning from OD to ND #79277

Closed

7 tasks

mountiny mentioned this pull request Jan 12, 2026

[CP Staging] Revert "fix: missing animations in" #79342

Closed

francoisl added a commit that referenced this pull request Jan 13, 2026

Revert "Merge pull request #76890 from margelo/fix/keyboard-controlle…

6654fea

…r-missing-animations" This reverts commit 6620f4c, reversing changes made to 6eb4a7e.

francoisl mentioned this pull request Jan 13, 2026

[CP Staging] Revert #76890 – "fix: missing animations in" #79399

Merged

63 tasks

francoisl added a commit that referenced this pull request Jan 13, 2026

Merge pull request #79399 from Expensify/francois-revert-76890

7cae749

[CP Staging] Revert #76890 – "fix: missing animations in"

OSBotify pushed a commit that referenced this pull request Jan 13, 2026

Merge pull request #79399 from Expensify/francois-revert-76890

0c60819

[CP Staging] Revert #76890 – "fix: missing animations in" (cherry picked from commit 7cae749) (cherry-picked to staging by francoisl)

melvin-bot bot mentioned this pull request Jan 13, 2026

[Due for payment soon?] [$250] ios 26 keyboard jumps when composer is being focused #75139

Open

16 tasks

fix: missing animations in #76890

fix: missing animations in #76890

Uh oh!

Conversation

kirillzyusko commented Dec 6, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Dec 6, 2025

Uh oh!

codecov bot commented Dec 6, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 6, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 19, 2025

Uh oh!

github-actions bot commented Dec 19, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

mountiny commented Jan 7, 2026

Uh oh!

situchan commented Jan 8, 2026

Uh oh!

ZhenjaHorbach commented Jan 8, 2026

Uh oh!

situchan commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Jan 8, 2026

Uh oh!

rohit9625 commented Jan 9, 2026

Uh oh!

ZhenjaHorbach commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rohit9625 commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 9, 2026

Uh oh!

OSBotify commented Jan 10, 2026

Uh oh!

francoisl commented Jan 13, 2026

Uh oh!

kirillzyusko commented Dec 6, 2025 •

edited by mountiny

Loading

codecov bot commented Dec 6, 2025 •

edited by github-actions bot

Loading

situchan commented Jan 8, 2026 •

edited

Loading

ZhenjaHorbach commented Jan 9, 2026 •

edited

Loading