Fix - legal name - Legal name fields don't allow hyphen so composed names can't be properly introduced #76842

FitseTLT · 2025-12-05T19:18:37Z

Explanation of Change

This PR fixes a regression to remove a constraint of only allowing latin characters for legal names. We want to allow any type of characters for legal names. here is a discussion for more context.

Fixed Issues

$ #74490
PROPOSAL: #74490 (comment)

Tests

Go to the Account option in the bottom menu
Tap on the Profile menu option
Scroll down to the Private section
Tap on the Legal Name field
Enter any name for both first name and last name
Verify that both name fields accept any characters, even special characters, unless the name includes reserved words like ["Expensify", "Concierge"].

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

2025-12-06.00-54-38.mp4

Android: mWeb Chrome

2025-12-05.22-17-30.mp4

iOS: Native

2025-12-05.21-36-24.mp4

iOS: mWeb Safari

2025-12-05.22-16-58.mp4

MacOS: Chrome / Safari

2025-12-05.22-16-30.mp4

melvin-bot · 2025-12-05T19:18:43Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2025-12-05T19:18:45Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-05T19:26:54Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...settings/Profile/PersonalDetails/LegalNamePage.tsx	`0.00% <ø> (ø)`
... and 8 files with indirect coverage changes

joekaufmanexpensify

Reasonable change

hungvu193 · 2025-12-06T06:04:40Z

We still need to wait for the translation confirmation right? @FitseTLT

FitseTLT · 2025-12-06T18:01:31Z

We still need to wait for the translation confirmation right? @FitseTLT

yes

hungvu193 · 2025-12-07T15:23:39Z

src/CONST/index.ts

        SPECIAL_CHARS_WITHOUT_NEWLINE: /((?!\n)[()-\s\t])/g,
        DIGITS_AND_PLUS: /^\+?[0-9]*$/,
        ALPHABETIC_AND_LATIN_CHARS: /^[\p{Script=Latin} ]*$/u,
+        ALPHABETIC_AND_LATIN_CHARS_WITH_HYPHEN: /^[\p{Script=Latin} -]*$/u,


I thought that we should only allow hyphen if it's followed by another character?

Otherwise, we can see something like this, it looks pretty weird and I don't think that's a valid name:

Screen.Recording.2025-12-07.at.22.23.11.mov

That was exactly what I was asking. @JmillsExpensify @trjExpensify WDYT about the above

Waiting on this @JmillsExpensify @trjExpensify

Mhm.. so let's take a step back on the history here.

We had an issue back in March for the same problem. CC: @dylanexpensify @stitesExpensify @allgandalf.

We had a conversation about it then (retain channel).
TL;DR of the outcome from @iwiznia.

Anything that's not empty is a valid name

A PR was merged to fix that here.

There was a request on the PR to make the necessary BE update(s) to go along with it before merging, but I can't see @stitesExpensify's linked PR(s) for that. Did that not happen?

It also seems like we didn't create a regression test issue to update the tests so Applause don't report it as a bug after it was changed. (CC: @dylanexpensify).

That seems to have led to an issue being created by Applause about bugs in the validation logic for the field, which @shubham1206agra commented on the original PR here as being the root cause of.

... and now we're here.

So, has anything changed between our last outcome and now? If not, then we're still expecting anything but an empty value is a valid legal name. This time, can we please make sure:

Any BE changes that need to be made is done first before the FE changes.

We create a regression test and engage Applause to avoid coming back to square one.

Thanks!

I'm up if we decide to allow any name other than empty string on the BE, lemme know 🙇

In this issue, we have implemented stricter rules for our legal name validation. However, the current validation allows hyphen character that's not followed by another Latin character, please see my comment.

I'd suggest that we should only hyphen if it's followed by another Latin character. For example:

hans-vu is valid name while hans-, -hans aren't.

Let me know your thoughts 😄

In this issue, we have implemented stricter rules for our legal name validation

What issue?

@hungvu193 would you be able to raise a discussion in slack, that way we all can communicate faster :)

This reverts commit 0a0b0b0.

This reverts commit 7289ebd.

FitseTLT · 2025-12-11T19:35:01Z

Updated @hungvu193

hungvu193 · 2025-12-12T01:58:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mChrome.mov

iOS: HybridApp

IOS.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Chrome.mov

hungvu193

Discussion in here: https://expensify.slack.com/archives/C01GTK53T8Q/p1765461123418859

The prettier is on main. I'll go ahead and approve.

LGTM.

allgandalf · 2025-12-12T05:14:36Z

NAB: @FitseTLT can you please update Explanation of Change section to reflect all the discussions we had around this issue, it helps a lot to backtrack the changes :) thanks!

MonilBhavsar · 2025-12-12T10:52:36Z

Prettier is failing

FitseTLT · 2025-12-12T12:53:45Z

Updated Explanation of change and tests passed. @MonilBhavsar

MonilBhavsar · 2025-12-12T13:47:08Z

thanks!

OSBotify · 2025-12-12T14:14:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-12T22:28:26Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-16T22:25:21Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

allowed hypens for legal names

0a0b0b0

FitseTLT requested review from a team as code owners December 5, 2025 19:18

melvin-bot bot assigned FitseTLT Dec 5, 2025

melvin-bot bot requested review from hungvu193 and joekaufmanexpensify and removed request for a team December 5, 2025 19:18

joekaufmanexpensify previously approved these changes Dec 5, 2025

View reviewed changes

hungvu193 suggested changes Dec 7, 2025

View reviewed changes

added copy

7289ebd

FitseTLT dismissed joekaufmanexpensify’s stale review via 7289ebd December 9, 2025 20:30

FitseTLT added 7 commits December 9, 2025 23:35

Merge branch 'main' into fix-app-not-allowing-hyphen-on-legal-names

804fa13

Merge branch 'main' into fix-app-not-allowing-hyphen-on-legal-names

8011078

Revert "allowed hypens for legal names"

3ed6ac5

This reverts commit 0a0b0b0.

Revert "added copy"

194d241

This reverts commit 7289ebd.

revert copy changes

51fc72e

revert

c32d2ff

allow any characters for legal names

cc66889

hungvu193 approved these changes Dec 12, 2025

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar December 12, 2025 01:59

Merge branch 'main' into fix-app-not-allowing-hyphen-on-legal-names

a177448

MonilBhavsar approved these changes Dec 12, 2025

View reviewed changes

MonilBhavsar merged commit be35fa2 into Expensify:main Dec 12, 2025
31 checks passed

OSBotify mentioned this pull request Dec 12, 2025

Deploy Checklist: New Expensify 2025-12-12 #77578

Closed

hungvu193 mentioned this pull request Dec 29, 2025

fix: validate legal name #66171

Merged

51 tasks

Fix - legal name - Legal name fields don't allow hyphen so composed names can't be properly introduced #76842

Fix - legal name - Legal name fields don't allow hyphen so composed names can't be properly introduced #76842

Uh oh!

Conversation

FitseTLT commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 5, 2025

Uh oh!

melvin-bot bot commented Dec 5, 2025

Uh oh!

codecov bot commented Dec 5, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Dec 6, 2025

Uh oh!

FitseTLT commented Dec 6, 2025

Uh oh!

hungvu193 Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FitseTLT Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

FitseTLT Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

trjExpensify Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

trjExpensify Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Dec 11, 2025

Uh oh!

hungvu193 commented Dec 12, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Dec 12, 2025

Uh oh!

MonilBhavsar commented Dec 12, 2025

Uh oh!

FitseTLT commented Dec 12, 2025

Uh oh!

MonilBhavsar commented Dec 12, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

FitseTLT commented Dec 5, 2025 •

edited

Loading

codecov bot commented Dec 5, 2025 •

edited by github-actions bot

Loading

hungvu193 Dec 7, 2025 •

edited

Loading