Add a focused style to the composer box #520
Conversation
sketchydroide
changed the title
| } | ||
|
|
||
| componentDidUpdate(prevProps) { | ||
| this.focusInput(); |
There was a problem hiding this comment.
I removed this one because whenever the composer is rendered it focus the text input again. I don't think that is the desired behaviour. Specially with the purpose of this PR
| * | ||
| * @param {boolean} shouldHighlight | ||
| */ | ||
| focusTextInput(shouldHighlight) { |
There was a problem hiding this comment.
I suggest renaming this method to setIsFocused since this method doesn't actually focus the text input.
| }, | ||
|
|
||
| chatItemComposeBoxFocusedColour: { | ||
| borderColor: colors.blue, |
There was a problem hiding this comment.
I think this comment makes it sound like we don't want blue, right @shawnborton?
There was a problem hiding this comment.
sorry, I forgot to update the GH for the expensify one here
it was agreed later that blue was the better option
There was a problem hiding this comment.
Ah missed that one, thanks!
| } | ||
|
|
||
| /** | ||
| * updates the Highlight state of the composer |
There was a problem hiding this comment.
| * updates the Highlight state of the composer | |
| * Updates the Highlight state of the composer |
src/style/StyleSheet.js
Outdated
| display: 'flex', | ||
| }, | ||
|
|
||
| chatItemComposeBoxColour: { |
There was a problem hiding this comment.
| chatItemComposeBoxColour: { | |
| chatItemComposeBoxColor: { |
src/style/StyleSheet.js
Outdated
| borderColor: colors.border, | ||
| }, | ||
|
|
||
| chatItemComposeBoxFocusedColour: { |
There was a problem hiding this comment.
| chatItemComposeBoxFocusedColour: { | |
| chatItemComposeBoxFocusedColor: { |
AndrewGable
dismissed
tgolen’s stale review
Stale review, changes were addressed and code looks good now!
fixes: https://github.com/Expensify/Expensify/issues/141643
Problem
the composer text input should have a focused style
Tests