Skip to content

Improve visibility awareness for Browser Notifications on web/desktop #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tgolen merged 7 commits into from
Sep 21, 2020
Merged

Improve visibility awareness for Browser Notifications on web/desktop #515

tgolen merged 7 commits into from
Sep 21, 2020

Conversation

@marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Sep 21, 2020 •
edited
Loading

cc @AndrewGable

Fixes: #332

@marcaaron marcaaron self-assigned this Sep 21, 2020
@marcaaron marcaaron marked this pull request as ready for review September 21, 2020 20:43
@marcaaron
Copy link
Contributor Author

marcaaron commented Sep 21, 2020

Alright have searched around for a bit and the signs are pointing towards this being a decent option for now. This was a weird one because Electron counts a "partially visible" window as "visible" and only counts "fully occluded" windows as "hidden". So if you have Chrome on top of Electron but Electron's toe is sticking out then you won't get any browser notifications.

@marcaaron
Copy link
Contributor Author

marcaaron commented Sep 21, 2020

Another option would be that we just live with this limitation and don't implement the IPC stuff until we need to.
If everyone wants to go that way for now I'd be cool with it.

tgolen
tgolen approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to use this when marking a thread as unread when a message comes into the thread currently being viewed (I was just thinking of making something like this).

@tgolen tgolen merged commit 389ab8f into master Sep 21, 2020
@tgolen tgolen deleted the marcaaron-visibility branch September 21, 2020 21:15
@snyk-bot snyk-bot mentioned this pull request May 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgolen tgolen tgolen approved these changes

@AndrewGable AndrewGable Awaiting requested review from AndrewGable

Assignees

@marcaaron marcaaron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcaaron @tgolen