Wallet - Confirm button is not shown on the currency selector page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #54798
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause - Internal Team
Component: User Settings

Action Performed:

1. Login to NewDot.
2. Go to Settings > Wallet > Add bank account
3. Click Add bank account
4. Select any county other than United States(or select India)
5. Click Next
6. Click the currency push row

Expected Result:

You see the Confirm button at the bottom

Actual Result:

Confirm button is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6722172_1737666570946.Screen_Recording_2025-01-24_at_12.00.48_at_night.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 02:04:56 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Confirm button is not shown

What is the root cause of that problem?

We do not show confirm button on selection list here

What changes do you think we should make in order to solve the problem?

If we just want to add Confirm button to the currency list in add bank account flow, Introduce showConfirmButton to CurrencySelectionList and CurrencyPicker. Then enable it in BankAccountDetails.

In CurrencyPicker, define SelectionList's onConfirm as:

onConfirm={(e, item) => updateInput(item)}

In order to do that, we need to update updateInput to accept optional item parameter.

App/src/components/CurrencyPicker.tsx

Line 33 in 034c4ca

const updateInput = (item: ValuePickerItem) => {

The confirm button here simply just navigate back when no thing new was selected.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Or we can modify the currency flow to work like CountrySelection where you need to select the country first and press Confirm to close the picker and save the selection. Currently in CurrencyPicker, press any currency row will automatically save it and close the picker.

[yuwenmemon]

@MonilBhavsar @shubham1206agra Seems like this is also related to #54798?

[shubham1206agra]

@yuwenmemon This was decided to be as expected. There will be confirm button in currency selection page. You can close this issue.