This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Makes tree accessible#1984

Merged

futuremint merged 58 commits intoExactTarget:masterfrom

cmcculloh-kr:GH1964---tree-should-be-accessible

Jun 15, 2017

Commits on Jun 14, 2017

fixes most eslint warnings and all errors
Christopher McCulloh
committed
fixes remaining eslint errors
Christopher McCulloh
committed
separates out tree dataSource to make the file more manageable
Christopher McCulloh
committed
breaks tree tests up into their own files to clean it up in preparation for adding a bunch more
Christopher McCulloh
committed
comment out other tests while developing
Christopher McCulloh
committed
cleans up unit tests more
Christopher McCulloh
committed
adds file for is-destroyed test
Christopher McCulloh
committed
wip on accessibility testing
Christopher McCulloh
committed
separates accessibility testing out into its own module
Christopher McCulloh
committed
WIP trying to test focusIn
Christopher McCulloh
committed
adds more shortcuts to helpers
Christopher McCulloh
committed
test focus on tree with no selected element. Tests tab index for focused element on focusIn
Christopher McCulloh
committed
fixes npm lint errors
Christopher McCulloh
committed
tests focusIn on select
Christopher McCulloh
committed
tests tabindexes
Christopher McCulloh
committed
tests setFocus method
Christopher McCulloh
committed
adds test for left key press on closed branch on top node
Christopher McCulloh
committed
test left key press on open folder
Christopher McCulloh
committed
uncomments out tests. Adds skip tests for stubbed out tests
Christopher McCulloh
committed
uses qunit 2.3.0 because 2.3.1 & 2.3.2 (current latest) are broken. All sorts of tests throw an error about an assertion executing after the test is complete
Christopher McCulloh
committed
(GH1964) fixes eslint errors
Christopher McCulloh
committed
(GH1964) adds tabindex=-1 to all tree node buttons
Christopher McCulloh
committed
(GH1964) makes root element tab-able. Cleans up node entity creation
Christopher McCulloh
committed
(GH1964) sets tab index on the correct node
Christopher McCulloh
committed
(GH1964) makes tabbing to tree select proper node
Christopher McCulloh
committed
(GH1964) properly handles selection in multiselect tree
Christopher McCulloh
committed
(GH1964) set up listener for keystrokes and listens for specific strokes
Christopher McCulloh
committed
(GH1964) documents what home, end, and enter should do for tree keyboard nav
Christopher McCulloh
committed
(GH1964) makes right arrow key work as expected in keyboard nav on tree
Christopher McCulloh
committed
(GH1964) makes initial tab selection use focusIn. Properly populates aria-activedescendant when focus is set
Christopher McCulloh
committed
(GH1964) updates comments
Christopher McCulloh
committed
(GH1964) makes left arrow work. Does not prevent default for non-handled events
Christopher McCulloh
committed
(GH1964) handles 'end' keypress by setting focus on last focusable node in tree
Christopher McCulloh
committed
(GH1964) handles 'home' keypress by setting focus on first focusable node in tree
Christopher McCulloh
committed
(GH1964) makes enter key work as expected when navigating tree with keyboard
Christopher McCulloh
committed
(GH1964) makes down arrow work for tree navigation
Christopher McCulloh
committed
(GH1964) makes up arrow work for tree navigation
Christopher McCulloh
committed
(GH1964) makes selection move to first newly loaded node when Enter key pressed over 'load more'. Fixes bug where hidden elements block keyboard navigation
Christopher McCulloh
committed
(GH1964) triggers events to make building on this functionality easier
Christopher McCulloh
committed
(GH1964) makes space bar function the same as enter since space is used for selecting/deselection according to spec. Adam might know a bit more about the nuance here and recommend making spacebar o…
Christopher McCulloh
committed
(GH1964) fire event on correct object
Christopher McCulloh
committed
(GH1964) updates test markup with accessibility changes
Christopher McCulloh
committed
(GH1964) DRY up some code
Christopher McCulloh
committed
(GH1964) don't process event if propagation is stopped
Christopher McCulloh
committed
(GH1964) fakes up some promises to help ensure actions are actually done before triggering listeners
Christopher McCulloh
committed
(GH1964) adds some comments around noPromise and populated.fu.tree
Christopher McCulloh
committed
Create test.js

Christopher McCulloh
authored and
Christopher McCulloh
committed
(GH1964) cleans up code a little bit by making a variable's live time much shorter
Christopher McCulloh
committed
(GH1964) adds underline to focused elements
Christopher McCulloh
committed
(GH1964) adds hbs support for aria-label and aria-labelledby
Christopher McCulloh
committed
(GH1964) adds aria-selected=true to selected items/folders in tree
Christopher McCulloh
committed
(GH1964) adds unit tests for aria-selected=true on tree
Christopher McCulloh
committed
(GH1964) adds aria-multiselectable="true" and aria-selected="false" to hbs tree template
Christopher McCulloh
committed
(GH1964) set aria-selected to false instead of removing it
Christopher McCulloh
committed
(GH1964) make tests look for aria-selected set to false instead of not existing
Christopher McCulloh
committed
(GH1964) targets the proper DOM node for making a selection on the tree
Christopher McCulloh
committed
(GH1964) sets root tree element tabindex to -1 on tree item focus so that shift+tab will work
Christopher McCulloh
committed

Commits on Jun 15, 2017

Merge remote-tracking branch 'upstream/master' into GH1964---tree-should-be-accessible
Christopher McCulloh
committed

Makes tree accessible#1984futuremint merged 58 commits intoExactTarget:masterExactTarget/fuelux:masterfrom cmcculloh-kr:GH1964---tree-should-be-accessiblecmcculloh-kr/fuelux:GH1964---tree-should-be-accessibleCopy head branch name to clipboard

Commits

Commits on Jun 14, 2017

Commits on Jun 15, 2017

Makes tree accessible#1984
futuremint merged 58 commits intoExactTarget:masterfrom
cmcculloh-kr:GH1964---tree-should-be-accessible