deps: Use python2 explicitly, to avoid FTBFS on modern systems #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern Linux distributions do not alias `python` to python2. Ptyhon's PEP394 goes into further detail, but _currently_ you should point to the Python version you expect to find as `python`. This fixes various FTBFS on modern Linux/macOS systems with no `python` alias. See: https://www.python.org/dev/peps/pep-0394/ See: TryGhost/node-sqlite3#1328 See: TryGhost/node-sqlite3#584 See: TryGhost/node-sqlite3#1443
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern Linux distributions do not alias
pythonto python2. Ptyhon'sPEP394 goes into further detail, but currently you should point to the
Python version you expect to find as
python.This fixes various FTBFS on modern Linux/macOS systems with no
pythonalias.
See: https://www.python.org/dev/peps/pep-0394/
See: TryGhost/node-sqlite3#1328
See: TryGhost/node-sqlite3#584
See: TryGhost/node-sqlite3#1443