Skip to content

Conversation

@nanaeaubry
Copy link
Contributor

This PR:

Update outdated references to WebMap and WebScene classes in some of the guide and samples doc.

Had to change a few places where the classes were still being used as well.

##TODO:
The Tonga Volcano Sample still references the older classes but the sample needs more than a few changes to accommodate the new classes so I did not change it here

@nanaeaubry nanaeaubry requested review from Copilot and jyaistMap and removed request for Copilot September 8, 2025 09:06
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates outdated references from deprecated WebMap and WebScene classes to the current Map and Scene classes throughout documentation and sample notebooks. The changes modernize the codebase to use the updated API classes while maintaining the same functionality.

  • Update import statements to use arcgis.map.Map and arcgis.map.Scene instead of the deprecated mapping module classes
  • Replace class instantiation calls and object references throughout documentation
  • Update property access patterns to use the new API structure (e.g., content.layers instead of direct property access)

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
samples/05_content_publishers/publishing_web_maps_and_web_scenes.ipynb Updates imports and documentation text references from WebMap/WebScene to Map/Scene
samples/05_content_publishers/publish_ogc_services.ipynb Updates import paths and documentation references
samples/05_content_publishers/Identify_Items_That_Use_Insecure_URLs.ipynb Updates imports and object instantiation to use new Map/Scene classes with updated property access
labs/display_web_scene.ipynb Updates imports, object creation, and property access for Scene class
labs/display_web_map.ipynb Updates imports, object creation, and property access for Map class
guide/10-mapping-and-visualization/working-with-web-maps-and-web-scenes.ipynb Updates documentation text and removes unused imports
guide/09-finding-places-with-geocoding/part1_what_is_geocoding.ipynb Updates documentation reference from WebMap to Map
guide/03-the-gis/cloning-content.ipynb Updates imports, object creation, and property access patterns
Comments suppressed due to low confidence (1)

samples/05_content_publishers/Identify_Items_That_Use_Insecure_URLs.ipynb:1

  • The property access pattern wm.basemap.basemap appears redundant with the nested .basemap attribute. This should likely be wm.basemap or verify the correct API structure for accessing basemap layers.
{

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jyaistMap jyaistMap merged commit e0482e6 into master Sep 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants