-
Notifications
You must be signed in to change notification settings - Fork 1.1k
OfflineContentManager guide #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,337 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the api reference for the service_format argument has many more options besides File Geodatabase and Shapefile - are these specifically feature services without an underlying feature class that we're referring to here that default to File Geodatabase or Shapefile? Might help to clarify waht is meant by "services without an underlying feature class".
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah true, I guess technically all of those are options, I've just never tested this process doing something besides file gdb or shapefile. I can get rid of that bit and be more clear about what the no underlying feature class thing means.
| @@ -0,0 +1,337 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It might help to provide a sentence or 2 providing guidance as to what to do with those error messages, or to at least say "you can troubleshoot reason why these items didn't import". The ending of the document felt very abrupt and kind of open ended to me.
- I think it would help to provide a conclusion paragraph as well.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, yeah that would be good to add. I was more trying to highlight not that the warnings come up, but that it was able to continue despite the messages.
jyaistMap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some comments and submitted #2313
ManushiM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 John's comments. Apart from that, do we want to explicitly mention that this is introduced in v2.4.1? None of our other guides reference the version the feature was added in.
It might help to also add few other potential uses/applications in the conclusion paragraph.
Good call, didn't notice I omitted the potential applications of it. I'll add a conclusion that includes applications. We do mention version numbers in some guides (experience builder, a couple random mapping ones off the top of the head). And even if not, I don't think it's a bad thing to have, so users can know if they need to upgrade their arcgis version to use something. |
Added some potential phrasing and formatting suggestions
|
@jyaistMap @ManushiM merged John's PRs and addressed the comments. Let me know what y'all think! Thank you. |
jyaistMap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- submitted #2317 to correct formatting and spelling change. Once that's merged I'll approve.
Correct misspelling and incorrectly formatted hyperlink
Created a basic guide for the offline content manager. Hoping to get this one in soon so it can be linked by the blog post. Besides any edits you'd suggest, lmk if there are any additional housekeeping things I need to do @jyaistMap