This repository was archived by the owner on Aug 22, 2023. It is now read-only.
refactor: make stake table impl generic over key type #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't understand why the test is failing: do you mind taking a peak in case you might have some idea? @mrain |
* update to the newest interface * refactor keyagg gadget * update doc * update test name * public inputs * remove cargo.lock * refactor qc gadgets * refactor qc gadgets * remove branch from jellyfish deps * updated comments * more comments
alxiong
added a commit
that referenced
this pull request
Jul 27, 2023
…#66) * reorg qc trait and impl * rename: QCValidation->QC, BitvectorQuorumCertificate->BitVectorQC, ::Proof->::QC, partial_sign->sign, active_keys->signers * add QC::trace() API * remove CheckedType since it's unused (and unclear why we need it) * add back check()->Result<QuorumSize> * feat: introduce trait StakeTableScheme * refactor: move most ST methods under trait impl * chore: renaming from pending,frozen,active to head,epoch_start,last_epoch_start * fix: add Cargo.lock to avoid CI error * use concrete StakeTableError instead of Self::Error * feat: implement an iter for PersistentMerkleNode * refactor: make stake table impl generic over key type (#81) * refactor: make stake table impl generic over key type * fix err * feat: QC key aggregate gadget (#74) * update to the newest interface * refactor keyagg gadget * update doc * update test name * public inputs * remove cargo.lock * refactor qc gadgets * refactor qc gadgets * remove branch from jellyfish deps * updated comments * more comments --------- Co-authored-by: Chengyu Lin <[email protected]> * wip: using generic ST api instead of StakeEntry * use IntoFields for VerKey, fix test to avoid projective coordinate mismatch * repin to jellyfish main * accept IntoIter instead of Vec * move simple_lookup to trait StakeTableScheme --------- Co-authored-by: Chengyu Lin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #76