Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions mistralrs-core/src/sequence.rs
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,7 @@ impl Sequence {
*self.state.read().unwrap(),
SequenceState::FinishedAborted
| SequenceState::FinishedIgnored
| SequenceState::Error
| SequenceState::Done(_)
)
}
Expand Down Expand Up @@ -1655,6 +1656,51 @@ mod tests {
)
}

#[test]
fn error_state_is_finished_for_paged_attention_cleanup() {
let seq = make_test_sequence();
seq.set_state(SequenceState::Error);

assert!(
seq.is_finished_paged_attn(),
"SequenceState::Error must be terminal for PagedAttention cleanup"
);
}

#[test]
fn paged_attention_finished_state_predicate_preserves_existing_states() {
for state in [
SequenceState::Done(StopReason::Length(0)),
SequenceState::FinishedAborted,
SequenceState::FinishedIgnored,
SequenceState::Error,
] {
let seq = make_test_sequence();
seq.set_state(state);

assert!(
seq.is_finished_paged_attn(),
"{state:?} should be terminal for PagedAttention cleanup"
);
}

for state in [
SequenceState::RunningPrompt,
SequenceState::RunningCompletion,
SequenceState::RunningPrefillPrompt,
SequenceState::Waiting,
SequenceState::Swapped,
] {
let seq = make_test_sequence();
seq.set_state(state);

assert!(
!seq.is_finished_paged_attn(),
"{state:?} should not be terminal for PagedAttention cleanup"
);
}
}

#[test]
fn prefill_v2_normal_sets_prefix_cache_len_for_multimodal_trimming() {
let mut seq = make_test_sequence();
Expand Down
Loading