Skip to content

Add chat history support to web chat app #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 23, 2025
Merged

Add chat history support to web chat app #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
520165f
Add chat history
EricLBuehler May 23, 2025
a2e2d64
Support renaming
EricLBuehler May 23, 2025
af44235
Start immediately with new chat
EricLBuehler May 23, 2025
58e2fa4
Add timestamp
EricLBuehler May 23, 2025
0e14d97
Prettier chat list
EricLBuehler May 23, 2025
ff997ed
Style
EricLBuehler May 23, 2025
83fff70
Delete chat
EricLBuehler May 23, 2025
1ecbd89
Fix copy button
EricLBuehler May 23, 2025
a7dee36
Fix markdown rendering
EricLBuehler May 23, 2025
d8fa686
Store things in cache
EricLBuehler May 23, 2025
25a9369
Store things in cache
EricLBuehler May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
*.a
.DS_Store
.idea
mistralrs-web-chat/cache
5 changes: 3 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions mistralrs-web-chat/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ uuid = "1.17.0"
image.workspace = true
clap = { workspace = true, features = ["derive"] }
indexmap.workspace = true
chrono = "0.4.41"
Copy link

@coderabbitai coderabbitai bot May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify chrono version for security updates.

The chrono dependency looks good for timestamp handling. Please verify you're using a recent stable version without known vulnerabilities.

🌐 Web query:

What is the latest stable version of the chrono crate for Rust, and are there any security advisories for version 0.4.41?

💡 Result:

Based on the search results, I can provide information about the chrono crate for Rust.

The latest stable version of the chrono crate appears to be 0.4.38, which was released on December 9, 2024, according to the GitHub releases information[2]. This release brought approximately 20% improvement to the performance of the formatting code and added a convenient days_since method for the Weekday type[2].

Regarding security advisories for version 0.4.41, there is no specific information about this version in the search results. However, the search results do mention past security advisories for the chrono crate:

In November 2020, CVE-2020-26235 and RUSTSEC-2020-0071 were opened against the time crate, which chrono depended on. This was later made into a security advisory against chrono as RUSTSEC-2020-0159[6][9]. The issue was related to calls to localtime_r being potentially unsound[6][9].

Since version 4.20, chrono no longer uses localtime_r and instead uses Rust code to query the timezone, addressing the previous security concerns[6][9]. Additionally, chrono has been working to remove its dependency on time 0.1, which had unaddressed security vulnerabilities. This change was implemented in chrono 0.4.30[9].

Without more recent information specifically about version 0.4.41, I cannot confirm whether there are any security advisories for that particular version.

Citations:

Confirm and pin chrono crate version

  • Cargo.toml currently specifies chrono = "0.4.41", but crates.io’s latest published stable release is 0.4.38 (December 9, 2024).
    • Please verify that 0.4.41 has actually been released; otherwise, change this to "0.4.38".
  • No security advisories have been reported for chrono versions ≥ 0.4.30 (past issues were fixed in 0.4.30).
🤖 Prompt for AI Agents 
In mistralrs-web-chat/Cargo.toml at line 31, verify if chrono version 0.4.41 is
officially released; if not, update the version to the latest stable release
0.4.38 to ensure compatibility and stability. Confirm no security advisories
affect versions 0.4.38 or later, then pin the chrono dependency explicitly to
"0.4.38" in Cargo.toml.


[features]
cuda = ["mistralrs/cuda"]
Expand Down
Loading
Loading