Skip to content

Fix image_to_pixels for non-RGB images #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged

Fix image_to_pixels for non-RGB images #1337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions mistralrs-vision/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@ use image::{DynamicImage, GenericImageView};
/// Output is (c, h, w)
pub(crate) fn image_to_pixels(image: &DynamicImage, device: &Device) -> Result<Tensor> {
let (w, h) = image.dimensions();
let data = image.to_rgb8().into_raw();
let data = Tensor::from_vec(data, (h as usize, w as usize, n_channels(image)), device)?;
let n_channels = n_channels(image);
let data = match n_channels {
1 => image.to_luma8().into_raw(),
2 => image.to_luma_alpha8().into_raw(),
3 => image.to_rgb8().into_raw(),
4 => image.to_rgba8().into_raw(),
_ => candle_core::bail!("Unsupported channel count {n_channels}"),
};
let data = Tensor::from_vec(data, (h as usize, w as usize, n_channels), device)?;
data.permute((2, 0, 1))?.to_dtype(DType::F32)
}

Expand Down
Loading