fix: prevent host header injection in email links#1267
Open
jwidan wants to merge 1 commit intoEqual-Vote:mainfrom
Open
fix: prevent host header injection in email links#1267jwidan wants to merge 1 commit intoEqual-Vote:mainfrom
jwidan wants to merge 1 commit intoEqual-Vote:mainfrom
Conversation
✅ Deploy Preview for bettervoting ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR patches a latent Host Header Injection vulnerability in the outbound email generation logic. While the production infrastructure currently shields the live server from this attack by enforcing explicit Host headers, the controllers implicitly trusted the client-supplied
Hostheader at the application layer. Without the external infrastructure mitigation, this would allow anyone to hijack the email origin and inject their own domains into the hyperlinks of mass email campaigns using SendGrid.req.get('host')usage from email controllersServiceLocator.globalData().mainUrl&&string interpolations into strict ternary operators inEmailTemplates.tsto prevent missing voter IDs from generating broken/falseURLs.