Write in candidates

[jacksonloper]

A very minimal write-in candidate frontend implementation based on Mike Franze's backend work. If write-ins are checked as allowed for a race....

Voter experience

Voter can add write in candidates to that race, which then get treated as if they were there the whole time by the frontend (these should be kept to the bottom since they are "special" like none of the above).

Frontend treats all trim-lowercase as the same "name" and so refuses to add JOHN if John has already been added.

Admin experience

Admin will see for those races a fun little new icon

If they click on it they will be taken to an approval page where they can approve or disapprove and set the official name of a write-in candidate

Results page

Tabulation then treats approved candidates as normal and others as ignored. User sees something like this in the results

Closing thoughts

This approach essentially (1) ignores capitalization (2) lets admin pick "real name" and (3) doesn't let admin merge "JFK" and "John F Kennedy". It is conceptually simple, weak, but i think viable for "ticking the box" in elections where bylaws require it. Basically election admins won't even know that our backend supports an aliasing system that can support admin-specified write-in merging. When we're ready (or if anyone asks for it) we can implement the rest.

Here's my rationale for not implementing frontend for the candidate merging in this PR: write-in-merging has insane edge cases. Here's one example, but I fear there may be lots like this. What if a voter makes writein "JFK" and gives them 3 stars and also "John F Kennedy" and gives them 5 stars in a multi-winner election, and admin merges "JFK" and "John F Kennedy"? How should ballot be counted? It would seem to necessitate either A Choice or else A Complicated User Interface for admins to handle the mess. I don't want to make either of those things if I can avoid it 😄.

[netlify]

✅ Deploy Preview for bettervoting ready!

Name	Link
🔨 Latest commit	a6daaf4
🔍 Latest deploy log	https://app.netlify.com/projects/bettervoting/deploys/69ab34042e9cb7000892f372
😎 Deploy Preview	https://deploy-preview-1262--bettervoting.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[jacksonloper]

The nefariousness-avoiding commit made tests fail!

When our ballots have "null" my nefariousness checker doesn't like it. In general submitting strings for ballots could be bad (think 0+"5" = "05" = cascading failure of tabulation 😂 ). I'll contemplate and make a plan tomorrow or next week!

[edit] yep fixed. its just a matter of accepting numbers OR nulls in the validation step. no need to ever accept strings.