-
Notifications
You must be signed in to change notification settings - Fork 3
feat: reload config on-demand #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
typotter
merged 17 commits into
main
from
typo/ff-4188-php-sdk-allow-reloading-configuration-ondemand
Mar 28, 2025
Merged
feat: reload config on-demand #44
typotter
merged 17 commits into
main
from
typo/ff-4188-php-sdk-allow-reloading-configuration-ondemand
Mar 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mock server which doesn't work properly on CI
typotter
commented
Mar 27, 2025
aarsilv
approved these changes
Mar 27, 2025
Contributor
aarsilv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thinking conforming to our new target public API! Approving assuming you update the log message text to be more relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes FF-4188
Motivation and Context
There are a number of use cases which require reloading the configuration on-demand. One such requirement is a more simplified polling approach where the configuration is reloaded via a script running on a cron.
Description
reloadConfigurationmethod on theconfigLoaderthroughEppoClient::fetchAndActivateConfigurationHow has this been documented?
FF-4189