[FFL-648] allowed pollAfterSuccessfulInitialization to be configurable #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
Aug 8, 2025
| // For server-side, we always want to keep polling for the life of the process | ||
| pollAfterSuccessfulInitialization: true, | ||
| // For server-side, we default to keep polling for the life of the process | ||
| pollAfterSuccessfulInitialization: config.pollAfterSuccessfulInitialization ?? true, |
Comment on lines
+734
to
+735
| const configurationRequestParameters = client['configurationRequestParameters']; | ||
| expect(configurationRequestParameters.pollAfterSuccessfulInitialization).toBe(false); |
Contributor
There was a problem hiding this comment.
Ideally we set a super short poll interval and verify it didn't actually try to poll, but I think peeking at the internals is fine enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
Description
How has this been documented?
How has this been tested?