Refactor event tracking config options for clarity. disabled by default #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghuels
reviewed
Mar 17, 2025
| batchSize?: number; | ||
| deliveryIntervalMs?: number; | ||
| disabled?: boolean; | ||
| enabled?: boolean; |
Contributor
There was a problem hiding this comment.
Nit: Do we actually need this at all? The eventTracking field is optional. If it's missing, it's disabled. If it's present, it's enabled. Forcing users to set an enabled field seems like an extra step that could be missed leading to confusion.
Contributor
Author
There was a problem hiding this comment.
I considered it, but passing in eventTracking: {} to enable it seemed weird, and asking users to decide on actual values to put into eventTracking is also not really necessary as we feel good about the defaults.
greghuels
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the
eventIngestionConfiginitialization option/param toeventTrackingto align with docs. Also updated the default value of this setting to disable event tracking, as customers who are not using event tracking have experienced issues with read-only filesystem checks in Vercel.How has this been tested?