chore: rename apiKey to sdkKey for consistency #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lingSafe to address naming collision with new base method
typotter
requested review from
aarsilv and
felipecsl
and removed request for
felipecsl
aarsilv
approved these changes
Feb 25, 2025
Collaborator
aarsilv
left a comment
aarsilv
left a comment
There was a problem hiding this comment.
Looks good!
The other changes were in that other PR
felipecsl
approved these changes
Feb 25, 2025
Contributor
felipecsl
left a comment
felipecsl
left a comment
There was a problem hiding this comment.
nice! long time coming
Collaborator
Author
GH automatically changed the base branch when I merged the other, but I hadn't rebased this one yet. Thanks for noting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eppo Internal
[//]: # (Link to the issue or doc corresponding to this chunk of work)
🎟️ fixes FF-4060
🧵 slack
Motivation and Context
We are renaming instances of API Key to SDK Key for
Description
EppoClientHow has this been documented?
FF-4061
How has this been tested?