Upgrade underlying common JDK SDK to get thread-safe MD5#195
Merged
Conversation
aarsilv
commented
Jun 6, 2025
Comment on lines
+3
to
+4
| id 'com.android.application' version '8.10.1' apply false | ||
| id 'com.android.library' version '8.10.1' apply false |
Contributor
Author
There was a problem hiding this comment.
Bumping this version as well at suggestion of Android Studio
|
|
||
| dependencies { | ||
| api 'cloud.eppo:sdk-common-jvm:3.10.0' | ||
| api 'cloud.eppo:sdk-common-jvm:3.11.2' |
Contributor
Author
There was a problem hiding this comment.
🔧 This is the core change/fix
| assertNotNull(parsedTimestamp); | ||
| assertTrue(parsedTimestamp.after(testStart)); | ||
| assertTrue(parsedTimestamp.before(assertionDate)); | ||
| assertTrue(parsedTimestamp.before(assertionDate) || parsedTimestamp.equals(assertionDate)); |
Contributor
Author
There was a problem hiding this comment.
If the test is executed really fast, the parsed and assertion timestamps will be equal, so changing this to an inclusive <= check so the test is not flakey.
sameerank
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eppo Internal:
🎟️ Ticket: FFL-169 - [Legacy Eppo][Android SDK] Use updated Common SDK for thread-safe MD5
👯 Related PR: [
sdk-common-jdk#128 - Thread-safe MD5](Thread-safe md5)🗨️ Slack: "...multiple threads add to the digest between resets ..."
Motivation and Context
Pulling in changes that will make hashing thread-safe
Description
Bumping version of
sdk-common-jdkused to one that has the fixHow has this been documented?
Internal change only--no documentation required
How has this been tested?