fix: build for cuda 13 + mac #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
dont merge. Let me add reactant builder here just to be safe |
Member
|
This builds way too many platforms clogging CI |
Member
|
https://github.com/EnzymeAD/ReactantBuilder/blob/9b5afc1cdafc7030064eed02b971c9efd02c01ca/R/Reactant/build_tarballs.jl#L741-L746 should be adapted first to account for this new job. |
Member
|
Relatedly we should also change that to include rocm too |
Member
|
longer term we probably should include a reactant_commit or something |
avik-pal
force-pushed
the
ap/hlo_ir_fixes
branch
from
9994001 to
c283ce7
Compare
avik-pal
force-pushed
the
ap/hlo_ir_fixes
branch
from
c283ce7 to
f4683eb
Compare
Collaborator
Author
|
what I am messing up here? this is clearly not the current commit |
avik-pal
commented
Nov 9, 2025
avik-pal
commented
Nov 9, 2025
avik-pal
force-pushed
the
ap/hlo_ir_fixes
branch
from
38a8b95 to
ebe1252
Compare
Collaborator
Author
|
@wsmoses builds are going through now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.