Skip to content

fix: add checks for running shardy without raising #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avik-pal merged 2 commits into from
Nov 4, 2025
Merged

fix: add checks for running shardy without raising #1823

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aff4c6
fix: add checks for running shardy without raising
avik-pal Nov 3, 2025
2ef33b8
fix: only run in the all case
avik-pal Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Compiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,6 +1738,8 @@ function compile_mlir!(
()
end

legal_to_run_shardy_passes = compile_options.optimization_passes !== :before_raise
Copy link
Member

@wsmoses wsmoses Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also may need before_jit


if compile_options.optimization_passes === :all
run_pass_pipeline!(
mod,
Expand Down Expand Up @@ -2173,7 +2175,7 @@ function compile_mlir!(
# shardy passes
use_shardy_partitioner = false
result_shardings = missing
if is_sharded
if is_sharded && legal_to_run_shardy_passes
module_op = copy(MLIR.IR.Operation(mod))
mod_copied = MLIR.IR.Module(module_op)

Expand Down
Loading