Add __nv_sincosf and __nv_sincos
#2586
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added NVIDIA’s
sincossymbols to the existingsincosCallPattern:Fixes #2552.
However, I am not sure this is actually correct, ChatGPT says the ABIs differ (below):
Current Enzyme test uses a struct‑return function, e.g.:
whereas the NVIDIA libdevice intrinsics are pointer‑out, void return:
So with this change I am effectively binding symbols with a
[2 x T] (T)ABI and symbols with avoid (T, T*, T*)ABI to the same CallPattern. I am worried this might be wrong or at least fragile, since the existing derivative logic for sincos appears to assume a non‑void aggregate return (as in ReverseMode/sincos.ll).I am not really sure how to test this, any pointers would be appreciated.