-
Notifications
You must be signed in to change notification settings - Fork 82
Implement support for finalizers #2736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
|
Motivated by #518 (comment) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2736 +/- ##
==========================================
- Coverage 70.01% 69.92% -0.09%
==========================================
Files 58 58
Lines 19300 19323 +23
==========================================
- Hits 13513 13512 -1
- Misses 5787 5811 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/19147239268/artifacts/4491418091. |
Co-authored-by: Lucas Wilcox <[email protected]>
e702ea9 to
00cbd6e
Compare
|
I am going to merge this, but I am happy to revisit it. |
|
retrospective lgtm |
As long as the finalizer is const this should be the right thing to do for most cases.