fix: infinite compile due to broadcast and iota indexing conflict #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/fix_inf_compile
branch
from
0108786 to
bb03b1b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
EnzymeJAX Benchmarks
Details
| Benchmark suite | Current: bb03b1b | Previous: cbaec25 | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.000004314572899966151 s |
0.000004326745998696424 s |
1.00 |
scatter_sum / JaXPipe / cpu / Primal |
0.000004282584999964456 s |
0.000004314442999020685 s |
0.99 |
scatter_sum / JaX / tpu / Primal |
0.0001558603576002 s |
0.0001427497209006 s |
1.09 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001575676035001 s |
0.0001392607529996 s |
1.13 |
This comment was automatically generated by workflow using github-action-benchmark.
Collaborator
Author
|
This does make all of the tests happy https://github.com/EnzymeAD/Reactant.jl/actions/runs/20124431829/job/57751107950?pr=1959. The few other remaining ones in the bump_jll PR are from missing the vector mode AD for dot_general |
wsmoses
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd one in the long list of things needed for EnzymeAD/Reactant.jl#1957.