fix: only raise ops with a single result (for now) #1721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/missing_check
branch
from
5733eef to
af97c87
Compare
wsmoses
approved these changes
Dec 11, 2025
Member
wsmoses
left a comment
wsmoses
left a comment
There was a problem hiding this comment.
for the future can you add a test?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
EnzymeJAX Benchmarks
Details
| Benchmark suite | Current: d6c8a26 | Previous: 0a0ee25 | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.000004329991000122391 s |
0.000004429214999981923 s |
0.98 |
scatter_sum / JaXPipe / cpu / Primal |
0.0000043566360000113495 s |
0.000004354909999892697 s |
1.00 |
scatter_sum / JaX / tpu / Primal |
0.0001519534668997 s |
0.0001464696221999 s |
1.04 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001512187027998 s |
0.0001298194633 s |
1.16 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will resolve EnzymeAD/Reactant.jl#1957 (comment)