Skip to content

Conversation

@vpanchal-supra
Copy link
Contributor

This PR adds a feature to send tx using a ledger wallet.

  • As ledger wallet does not support sending a tx and it only supports signing message, hence in this PR we have added sendTxUsingSerializedRawTransactionAndSignature which expects serializedRawTransaction and a signature obtained from ledger wallet.
  • There is also a breaking change, sendSponsorTransaction, sendMultiAgentTransaction and simulateTxUsingSerializedRawTransaction does not expects senderAccountAddress

Usage guidelines for Starkey wallet team,

  • Starkey Wallet can interact with the Supra ledger wallet app as they interact with the Aptos ledger wallet app.
  • Signature for tx can be obtained from the Supra ledger wallet app same as the Aptos ledger wallet app.
  • Leder wallet expects signature_message to generate a signature so for that getSupraTransactionSignatureMessage can be used to get signature_message
  • Once the signature is obtained from the ledger wallet, call sendTxUsingSerializedRawTransactionAndSignature to send tx.

@vpanchal-supra vpanchal-supra merged commit d6b3fe5 into master Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants