[Bugfix] Fix two tests in coin module #308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix two tests in the
coinmodule. In short, the tests failed due to the unconsistenty: we updated the two tests as in framework v1.34, but did not update some of the functions, which the tests depend on, to v1.34 exactly.test_migration_with_existing_primary_fungible_store. We changeback to
as before the framework update, which is the expected behavior since we did not enable
NEW_ACCOUNTS_DEFAULT_TO_FA_SUPRA_STOREas in the updated framework.test_migration_coin_store_with_non_coin_type. We change the expected behavior back toand revert the deleted
as before the framework update.
The test does not abort in v1.34 because the aborting line
is guarded by