forked from aptos-labs/aptos-core
-
Notifications
You must be signed in to change notification settings - Fork 12
feat(types): Add feature to RLP encode contract events. #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
n-puzankov-supra
wants to merge
8
commits into
dev
Choose a base branch
from
implement-rlp-encoding-for-contract-events
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
766bcb0 to
16cbf0d
Compare
16cbf0d to
2b212fd
Compare
2fd5070 to
cf2ae69
Compare
… events emissions proofs. - RLP's `Encodable` trait implementation for Contract Events. - `get_proof_by_position` method for Merkle Accumulator.
cf2ae69 to
c3f6e9f
Compare
…or-contract-events correction on cli instruction
…ed Full-Clone on `EventV2`
73fbe23 to
6fd76be
Compare
…vent` to `EventV2`
isaacdoidge
reviewed
Jan 29, 2026
isaacdoidge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
Comment on lines
+51
to
+63
| mod tests { | ||
| #[cfg(feature = "rest_api_schema")] | ||
| #[test] | ||
| fn feature() { | ||
| use crate::proof::{AccumulatorProof, TransactionAccumulatorHasher}; | ||
|
|
||
| #[derive(utoipa::ToSchema)] | ||
| pub struct TransactionInclusionProof { | ||
| #[schema(value_type = AccumulatorProof<u64>)] | ||
| pub proof: AccumulatorProof<TransactionAccumulatorHasher>, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this code for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.