-
Notifications
You must be signed in to change notification settings - Fork 12
fix move docs #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix move docs #181
Conversation
nizam-supraoracles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also replace instances of "aptos framework", "AptosGovernance" and "aptos governance", "AbortsIfNotAptosFramework" with "supra framework", "SupraGovernance", "supra governance", "AbortsIfNotSupraFramework" respectively.
You found this words when you globally search inside the aptos-move/framework/supra-framework
fixed in 662a698 |
nizam-supraoracles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed updating the .md file in aptos-move/framework/supra-framework/doc in your previous commit. This file is auto-generated.
Other than that, everything else looks good from my end.
We should avoid update any auto-generated files directly, otherwise it ends up inconsistency again soon. |
* fix move docs * fix docs * addressing comments * addressing comments * generate .md
* add cors for localnet * add docs and default * docs * docs * integration with smr * fix move docs (#181) * fix move docs * fix docs * addressing comments * addressing comments * generate .md * fix bls test * add todo docs * update generated .md files * update .md docs * derive evm chain id from move chainid * get chainid method * fix docs only
Due to we only change
AptostoSuprain .md file (generated doc) instead of the source of the docs in move, everytime we change single line framework, the regenereated .md will result in many modified .md filesIt make it hard to know what changes are really made by developer.
this pr change all docs in move file to use
Supraword instead ofAptosThis target to go together with evm config PR