Skip to content

Conversation

@so-schen
Copy link

@so-schen so-schen commented Feb 14, 2025

Due to we only change Aptos to Supra in .md file (generated doc) instead of the source of the docs in move, everytime we change single line framework, the regenereated .md will result in many modified .md files

It make it hard to know what changes are really made by developer.

this pr change all docs in move file to use Supra word instead of Aptos

This target to go together with evm config PR

Copy link

@nizam-supraoracles nizam-supraoracles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also replace instances of "aptos framework", "AptosGovernance" and "aptos governance", "AbortsIfNotAptosFramework" with "supra framework", "SupraGovernance", "supra governance", "AbortsIfNotSupraFramework" respectively.

You found this words when you globally search inside the aptos-move/framework/supra-framework

@so-schen
Copy link
Author

We should also replace instances of "aptos framework", "AptosGovernance" and "aptos governance", "AbortsIfNotAptosFramework" with "supra framework", "SupraGovernance", "supra governance", "AbortsIfNotSupraFramework" respectively.

fixed in 662a698

Copy link

@nizam-supraoracles nizam-supraoracles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed updating the .md file in aptos-move/framework/supra-framework/doc in your previous commit. This file is auto-generated.
Other than that, everything else looks good from my end.

@so-schen
Copy link
Author

so-schen commented Feb 17, 2025

You missed updating the .md file in aptos-move/framework/supra-framework/doc in your previous commit. This file is auto-generated. Other than that, everything else looks good from my end.

We should avoid update any auto-generated files directly, otherwise it ends up inconsistency again soon.
I will regenerate the files, thanks

@so-schen so-schen merged commit 8892ed7 into sc/evm-config Feb 17, 2025
@so-schen so-schen deleted the sc/fix-docs branch February 17, 2025 13:44
so-schen added a commit that referenced this pull request Feb 24, 2025
* fix move docs

* fix docs

* addressing comments

* addressing comments

* generate .md
so-schen added a commit that referenced this pull request Apr 25, 2025
* add cors for localnet

* add docs and default

* docs

* docs

* integration with smr

* fix move docs (#181)

* fix move docs

* fix docs

* addressing comments

* addressing comments

* generate .md

* fix bls test

* add todo docs

* update generated .md files

* update .md docs

* derive evm chain id from move chainid

* get chainid method

* fix docs only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants