Cannot copy code from github pr file changed tab

[cncolder]

After installing this extension. I cannot copy code from github pr File changed tab.

CMD+C or context menu.

Gitako v2.7.1

Recording: https://p-myf5wv.b3.n0.cdn.getcloudapp.com/items/wbu9qQee/8489acf7-cdfe-4456-9b63-357071cec5e6.gif

[kbsali]

I can confirm the same issue on Brave (Chromium). It works correctly on Firefox however.

[EnixCoda]

Thanks for this issue! I can confirm this in Chrome now.

Interesting. Gitako is not expected to block copying. I'll look into it later.

Hope it does not annoy you much :)

[EnixCoda]

I have some new findings. This issue only happens when

1. Gitako is enabled
2. And the user has logged in to GitHub

And only happens when copy from elements within diff panels.

[EnixCoda]

🤯

The issue is fixed after removing an unused CSS class in a0f6ad3 , .invisible, whose functionality is setting the element's visibility to hidden. The class was created since the very first few commits of Gitako at about 3 years ago and soon deprecated. I forgot to removed it in time so that it was kept until today.

When copy event is triggered inside the diff panels, GitHub's script will append a new table element into DOM to sanitize the text to be copied. By coincidence, the element is of the exact same class name mentioned above, invisible.

Thus the table element is not actually rendered, which is Chrome/Chromium's way of handling elements of visibility: hidden I guess, and the copy action fails.

What a bug.

[kbsali]

Great news, I'll give it a new try on Chrome then (I switched back to octotree in the meantime! :)).
Thanks for the hard work and the follow up!

[EnixCoda]

@kbsali I'll let you know when the next version is released :)

[EnixCoda]

The patch has been released in v2.7.2.

cc @kbsali

[kbsali]

perfect, thanks!