Initialize encoding/decoding buffers with null pointers closes #1#3
Merged
EndPositive merged 1 commit intomainfrom Jun 9, 2025
Merged
Initialize encoding/decoding buffers with null pointers closes #1#3EndPositive merged 1 commit intomainfrom
EndPositive merged 1 commit intomainfrom
Conversation
closes #1 > the caller has no way to know if they need to free it or not while this is not necessarily true--the buffer is only allocated on succesful return codes--it is indeed better practice to ensure the pointers are nullified. This prevents future accidental mal-use leading to corruption when freeing an uninitialized pointer.
x-stp
reviewed
Jun 6, 2025
Collaborator
x-stp
left a comment
x-stp
left a comment
There was a problem hiding this comment.
This looks solid!
a bit out of scope, but the slipstream_packet_loop_ func may leak mem when either encode/ decode callbacks allocate memory -> report an error (by returning a value <= 0). The loop immediately exits or continues defer / freeing the memory that was allocated; besides that
LGTM!
x-stp
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while this is not necessarily true--the buffer is only allocated on succesful return codes--it is indeed better practice to ensure the pointers are nullified. This prevents future accidental mal-use leading to corruption when freeing an uninitialized pointer.