Skip to content

feat: Energy as a service payment plan.#1403

Open
beesaferoot wants to merge 9 commits intomainfrom
energy-based-installments
Open

feat: Energy as a service payment plan.#1403
beesaferoot wants to merge 9 commits intomainfrom
energy-based-installments

Conversation

@beesaferoot
Copy link
Copy Markdown
Contributor

@beesaferoot beesaferoot commented Mar 27, 2026

Closes #1365

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@beesaferoot beesaferoot requested a review from dmohns March 27, 2026 15:19
@dmohns
Copy link
Copy Markdown
Member

dmohns commented Mar 31, 2026

Looking amazing!!! Few comments

image
  • I like the helper text. Could you add something along the lines of: "The device will stay owned by the service provider and no unlock tokens are send to the customer" Making clear that we won't generate unlock tokens?
  • I find the Minimum Payable Amount (access to the system for a day) field confusing. Could you try to clarify whether this field is given in Money or in days? For example, let's say rate per day = $10, and the minimum would be 3 days = $30. What should I enter as a user?
  • For EaaS, can we adapt this view:
image

to display information about the rates? I.e. what one day costs

  • The Get Payment button is grayed out when I'm running it locally
image
  • This is a more conception thought: EaaS and Meter Tariffs are extremely similar. Have we considered to maybe combine them? A thought could be to let users define a EaaSTariff and then, in the EaaS dialog just select the corresponding EaaSTariff. I assume companies would have very similar tariffs for all of their customers. But this could also be a future improvement.

@beesaferoot
Copy link
Copy Markdown
Contributor Author

@dmohns you should get a different view from what showed on your screenshot. Did you run the latests tenant migration?

Screenshot 2026-03-31 at 10 45 02 PM

@beesaferoot
Copy link
Copy Markdown
Contributor Author

beesaferoot commented Mar 31, 2026

I will address the top comments above and any other comment you may have after running the latest frontend view.

  • This is a more conception thought: EaaS and Meter Tariffs are extremely similar. Have we considered to maybe combine them? A thought could be to let users define a EaaSTariff and then, in the EaaS dialog just select the corresponding EaaSTariff. I assume companies would have very similar tariffs for all of their customers. But this could also be a future improvement.

Do you mind creating this as an issue? I think it will be a good improvement to make once we get the EaaS payment plan working.

Done here: #1423

@dmohns
Copy link
Copy Markdown
Member

dmohns commented Apr 1, 2026

Hey @beesaferoot

Nice, pulling the latest changes fixes the UI. Looks perfect now 👌

One more follow up comment: Could we try to make the distinction between down payment and EaaS rate more clear? For example in all of the below places

The SoldAppliance detail page:

image

Transaction Overview:

image

Even on Database level:

image

EaaS rates are not really deferred payment, hence we shouldn't track them as such. If possible, we could have down_payment for the down payment. eaas_rate (or maybe a better name).

@beesaferoot
Copy link
Copy Markdown
Contributor Author

@dmohns I've addressed your comments. Kindly review

@dmohns
Copy link
Copy Markdown
Member

dmohns commented Apr 2, 2026

@dmohns I've addressed your comments. Kindly review

Hey @beesaferoot I can't see any commits after my last comment 🤨 Have you pushed your latest changes?

@beesaferoot
Copy link
Copy Markdown
Contributor Author

@dmohns I've addressed your comments. Kindly review

Hey @beesaferoot I can't see any commits after my last comment 🤨 Have you pushed your latest changes?

I assumed I pushed the change. Sorry.

@dmohns
Copy link
Copy Markdown
Member

dmohns commented Apr 2, 2026

Looks good 👍

Any chance we can get to show Down Payment vs EaaS rate here:

image

Slight inconsistency:

Could you make this appear consistent to how it's displayed on Transaction page?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support Energy-as-a-Service use-case

2 participants